cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COCOON3-51) XIncludeTransformer sends extra startDocument and endDocument events
Date Sat, 30 Jan 2010 21:57:34 GMT

    [ https://issues.apache.org/jira/browse/COCOON3-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806746#action_12806746
] 

Simone Tripodi commented on COCOON3-51:
---------------------------------------

very very appreciated Charles, thanks, test is meaningful and way of submitting patches is
now much better, but please keep in mindfor the future patches you'll submit, when adding
new resources, like the XML test, please add the Apache License header.

I would avoid adding an external dependency in the XIncludeTransformer that's a dependencies-less
class. I'm sure there is a bug on the use of 'xIncludeElementLevel' class field, which scope
is also avoiding the bug you noticed.

BTW, well done ;)

> XIncludeTransformer sends extra startDocument and endDocument events
> --------------------------------------------------------------------
>
>                 Key: COCOON3-51
>                 URL: https://issues.apache.org/jira/browse/COCOON3-51
>             Project: Cocoon 3
>          Issue Type: Bug
>          Components: cocoon-sax
>    Affects Versions: 3.0.0-alpha-3
>            Reporter: Charles Yates
>            Assignee: Simone Tripodi
>         Attachments: COCOON3-51.txt, patch.txt
>
>
> The XIncludeTransformer sends extra start and endDocument events causing errors in subsequent
handlers.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message