From dev-return-101989-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org Sat Dec 05 08:41:45 2009 Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 43700 invoked from network); 5 Dec 2009 08:41:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Dec 2009 08:41:44 -0000 Received: (qmail 75494 invoked by uid 500); 5 Dec 2009 08:41:44 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 75395 invoked by uid 500); 5 Dec 2009 08:41:44 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 75386 invoked by uid 99); 5 Dec 2009 08:41:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Dec 2009 08:41:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Dec 2009 08:41:41 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 9A8E1234C045 for ; Sat, 5 Dec 2009 00:41:20 -0800 (PST) Message-ID: <467377389.1260002480618.JavaMail.jira@brutus> Date: Sat, 5 Dec 2009 08:41:20 +0000 (UTC) From: "Jos Snellings (JIRA)" To: dev@cocoon.apache.org Subject: [jira] Created: (COCOON3-46) URLConnectionUtils.closeQuietly() complains loudly if servletConnection == null MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org URLConnectionUtils.closeQuietly() complains loudly if servletConnection == null ------------------------------------------------------------------------------- Key: COCOON3-46 URL: https://issues.apache.org/jira/browse/COCOON3-46 Project: Cocoon 3 Issue Type: Improvement Components: cocoon-pipeline Affects Versions: 3.0.0-alpha-2 Reporter: Jos Snellings Assignee: Cocoon Developers Team Priority: Minor Fix For: 3.0.0-alpha-3 finally clause in URLResponse method execute() contains call to URLConnectionUtils.closeQuietly. If servletConnection = this.url.openConnection(); fails, servletConnection is null. In that case closeQuietly causes a stacktrace to be output. Solution is if (servletConnection != null) URLConnectionUtils.closeQuietly(servletConnection);, guard the call with a test, or even better, take into account in closeQuietly that the input parameter may be null. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.