cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reinhard Pötz <reinh...@apache.org>
Subject Re: SAXGenerator - URLGenerator
Date Mon, 21 Dec 2009 14:35:10 GMT
Joerg Heinicke wrote:
> On 14.12.2009 09:33, Reinhard Pötz wrote:
> 
>>> On Sun, Dec 13, 2009 at 3:59 PM, Joerg
>>> Heinicke<joerg.heinicke@gmx.de>  wrote:
> 
>>>> A long time ago I argued for renaming the FileGenerator to XMLGenerator
>>>> since the generators are usually named after the input they accept
>>>> (Midi,
>>>> HTML, Directory, JSP, JXTemplate, etc.). I'm not sure SAXGenerator
>>>> reflects
>>>> that exactly but it's good enough I guess.
>>
>> I agree that we should have one consistent naming scheme and since we
>> usually use the input type, we shouldn't change it for this case.
>>
>> I see two solutions in order to get a consistent naming of our
>> components:
>>
>> a) We rename SAXGenerator AND StAXGenerator to XMLGenerator
>>
>> or
>>
>> b) We add the SAX prefix to all pipeline components.
>>
>> I'm in favor of a) because SAX or StAX is already part of the package
>> name and looking at the implemented interfaces makes it clear what
>> underlying event mechanism is used.
> 
> I agree with your reasoning.

Thanks! Since none objected, I've just committed the changes. The
SAXGenerator/FileGenerator is called XMLGenerator and I also renamed the
StAXGenerator and StAXSerializer to XMLGenerator and XMLSerializer.

-- 
Reinhard Pötz                           Managing Director, {Indoqa} GmbH
                         http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member                  reinhard@apache.org
________________________________________________________________________

Mime
View raw message