cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reinhard Pötz <reinh...@apache.org>
Subject Re: SAXGenerator - URLGenerator
Date Mon, 14 Dec 2009 08:33:27 GMT
Simone Tripodi wrote:
> Hi all,
> I'd follow the Joerg suggestion since it reminded me the Neko HTML
> Generator included in the optional module that has the behavior
> similar to the old FileGenerator that takes an URL in input and
> transforms HTML in XHTML.
> 
> At that point I'd suggest to have an AbstractGenerator that manipulate
> an URL stream, than having different specialization, like:
> *) SAXGenerator
> *) NekoGenerator
> *) Anyhing else?
> 
> How does it sound?
> Simo
> 
> On Sun, Dec 13, 2009 at 3:59 PM, Joerg Heinicke <joerg.heinicke@gmx.de> wrote:
>> On 13.12.2009 14:44, Reinhard Pötz wrote:
>>> Long time ago (I think when the StAX module was added) we discussed to
>>> have a SAXGenerator which is mainly useful when the pipeline API is
>>> used. It has constructors for File, InputStream, String and Node. See
>>>
>>> http://svn.apache.org/repos/asf/cocoon/cocoon3/trunk/cocoon-sax/src/main/java/org/apache/cocoon/sax/component/SAXGenerator.java
>>>
>>> I also renamed FileGenerator to URLGenerator because this better
>>> reflects what it really does.
>>>
>>> But thinking more about this it would also make sense to merge the
>>> URLGenerator into the SAXGenerator.
>>>
>>> WDYT?
>> A long time ago I argued for renaming the FileGenerator to XMLGenerator
>> since the generators are usually named after the input they accept (Midi,
>> HTML, Directory, JSP, JXTemplate, etc.). I'm not sure SAXGenerator reflects
>> that exactly but it's good enough I guess.

I agree that we should have one consistent naming scheme and since we
usually use the input type, we shouldn't change it for this case.

I see two solutions in order to get a consistent naming of our components:

a) We rename SAXGenerator AND StAXGenerator to XMLGenerator

or

b) We add the SAX prefix to all pipeline components.

I'm in favor of a) because SAX or StAX is already part of the package
name and looking at the implemented interfaces makes it clear what
underlying event mechanism is used.

-- 
Reinhard Pötz                           Managing Director, {Indoqa} GmbH
                         http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member                  reinhard@apache.org
________________________________________________________________________

Mime
View raw message