cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Heinicke (JIRA) <j...@apache.org>
Subject [jira] Commented: (COCOON3-46) URLConnectionUtils.closeQuietly() complains loudly if servletConnection == null
Date Sat, 05 Dec 2009 09:50:20 GMT

    [ https://issues.apache.org/jira/browse/COCOON3-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786368#action_12786368
] 

Jörg Heinicke commented on COCOON3-46:
--------------------------------------

Isn't it more convenient if closeQuietly(..) just handles null?

> URLConnectionUtils.closeQuietly() complains loudly if servletConnection == null
> -------------------------------------------------------------------------------
>
>                 Key: COCOON3-46
>                 URL: https://issues.apache.org/jira/browse/COCOON3-46
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Jos Snellings
>            Assignee: Cocoon Developers Team
>            Priority: Minor
>             Fix For: 3.0.0-alpha-3
>
>
> finally clause in URLResponse method execute()
> contains call to URLConnectionUtils.closeQuietly.
> If  servletConnection = this.url.openConnection(); fails, servletConnection is null.
> In that case closeQuietly causes a stacktrace to be output.
> Solution is if (servletConnection != null) URLConnectionUtils.closeQuietly(servletConnection);,
guard the call with a test,
> or even better, take into account in closeQuietly that the input parameter may be null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message