Return-Path: 
 <dev-return-101706-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org>
Delivered-To: apmail-cocoon-dev-archive@www.apache.org
Received: (qmail 22902 invoked from network); 29 Jul 2009 20:28:06 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 29 Jul 2009 20:28:06 -0000
Received: (qmail 91255 invoked by uid 500); 29 Jul 2009 20:28:06 -0000
Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org
Received: (qmail 91149 invoked by uid 500); 29 Jul 2009 20:28:06 -0000
Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@cocoon.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@cocoon.apache.org>
List-Post: <mailto:dev@cocoon.apache.org>
Reply-To: dev@cocoon.apache.org
List-Id: <dev.cocoon.apache.org>
Delivered-To: mailing list dev@cocoon.apache.org
Received: (qmail 91141 invoked by uid 99); 29 Jul 2009 20:28:06 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jul 2009 20:28:06 +0000
X-ASF-Spam-Status: No, hits=-1.0 required=10.0
	tests=RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of ap-cocoon-dev@m.gmane.org
 designates 80.91.229.2 as permitted sender)
Received: from [80.91.229.2] (HELO ciao.gmane.org) (80.91.229.2)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jul 2009 20:27:56 +0000
Received: from list by ciao.gmane.org with local (Exim 4.43)
	id 1MWFkK-0003W3-9w
	for dev@cocoon.apache.org; Wed, 29 Jul 2009 20:27:32 +0000
Received: from dhcp-vpn-89-206-68-11.uzh.ch ([89.206.68.11])
        by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <dev@cocoon.apache.org>; Wed, 29 Jul 2009 20:27:32 +0000
Received: from andreas by dhcp-vpn-89-206-68-11.uzh.ch with local (Gmexim 0.1
 (Debian))
        id 1AlnuQ-0007hv-00
        for <dev@cocoon.apache.org>; Wed, 29 Jul 2009 20:27:32 +0000
X-Injected-Via-Gmane: http://gmane.org/
To: dev@cocoon.apache.org
From: Andreas Hartmann <andreas@apache.org>
Subject: [2.2] Global objectModel in JX components
Date: Wed, 29 Jul 2009 22:27:22 +0200
Lines: 33
Message-ID: <h4qbba$hr4$1@ger.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Complaints-To: usenet@ger.gmane.org
X-Gmane-NNTP-Posting-Host: dhcp-vpn-89-206-68-11.uzh.ch
User-Agent: Thunderbird 2.0.0.22 (Macintosh/20090605)
Sender: news <news@ger.gmane.org>
X-Virus-Checked: Checked by ClamAV on apache.org

Hi Cocoon devs,

I just noticed that the JX template generator uses a global object model 
in the execution context. This leads to problems when multiple JX 
template generators are called concurrently, e.g. if the processed 
template contains includes:

<template>

   ${cocoon.parameters.foo} -> "foo"

   <i:include src="…"/> (some JX generator, with parameter foo=bar)

   ${cocoon.parameters.foo} -> "bar"

</template>

The included JX template generator overwrites the cocoon/parameters 
object in the object model, which affects the outer template.

Would it make sense to pass a copy of the object model to the invoker 
instead of a reference to the global object model?

TIA for any comments!

-- Andreas


-- 
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
Tel.: +41 (0) 43 818 57 01