cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reinhard Pötz <reinh...@apache.org>
Subject Re: Useless if statement Cocoon 3 cocoon-sitemap in WildcardMather.java
Date Mon, 30 Mar 2009 10:56:14 GMT
Dariusz Łuksza wrote:
> Hi,
> 
> While browsing Cocoon 3 soruces I found useless if statemnt in module
> cocoon-sitemap, class WidcardMather line 41. If variable
> matchingResult is null method would return null (line 37) and another
> check if matchingResult is not null in line 41 unecessary.
> 
> Correct me if I'm wrong.

No, you are right. I've applied your patch. Thank you very much!

-- 
Reinhard Pötz                           Managing Director, {Indoqa} GmbH
                         http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member                  reinhard@apache.org
________________________________________________________________________

Mime
View raw message