cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Grzegorz Kossakowski <g...@tuffmail.com>
Subject Re: [C3] redirect-to/@uri optional?
Date Sat, 14 Mar 2009 11:17:07 GMT
Reinhard Pötz pisze:
>> So do you agree with me changing both schema and implementation so @uri is required?
> 
> yes, go ahead

Done in r753635.

>>>> The same concern (about too many of optional attributes) applies to
>>>> call instruction.
>> What about this?
> 
> @controller and @select could be mandatory. Once I was thinking about
> having a default controller for a sitemap (e.g. defined at the root
> element) but have never implemented it. It that case @controller would
> have to become optional.

I've made them required in r753634.

>> Right. I wasn't active committer at that time so I can't remember original goals
of TreeProcessor. Anyway, I wonder if
>> this functionality was ever used in 2.x? I can't recall such a situation.
>>
>> If I understand it correctly having extensible sitemap language adds quite a lot
to complexity of sitemap
>> implementation. I would like to know what kind of issues extensibility of sitemap
language solves.
> 
> There was the idea of designing page flows in XML (very similar to
> Spring MVC) but this idea was dropped in favor of Flowscript. You can
> guess now how old this idea has to be ;-)
> Nowadays I don't know of any use case but when we implemented
> cocoon-sitemap we thought that we should make it extensible, especially
> because the sitemap module can be used stand-alone very easily.

I see. Thanks for explaining it to me.

I do not fully agree with the point that sitemap should be extensible but we'll discuss this
in Amsterdam. At least I
hope so.

-- 
Best regards,
Grzegorz Kossakowski


Mime
View raw message