cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Dolg (JIRA)" <j...@apache.org>
Subject [jira] Updated: (COCOON3-30) The current implementation of the ParameterCacheKey actually breaks the caching
Date Tue, 10 Feb 2009 14:47:19 GMT

     [ https://issues.apache.org/jira/browse/COCOON3-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Steven Dolg updated COCOON3-30:
-------------------------------

    Attachment: parametercachekey.patch

This patch changes the implementation of equals() and hashcode() to actually use the parameters.

While this results in correct behaviour, it will also prevent asynchronous caching.
I believe that this type of CacheKey cannot provide both synchronous and asynchronous caching
and thus think this is the proper solution.

I will delay committing this patch for some days, just in case someone comes up with a different
opinion...

> The current implementation of the ParameterCacheKey actually breaks the caching
> -------------------------------------------------------------------------------
>
>                 Key: COCOON3-30
>                 URL: https://issues.apache.org/jira/browse/COCOON3-30
>             Project: Cocoon 3
>          Issue Type: Bug
>          Components: cocoon-pipeline
>    Affects Versions: 3.0.0-alpha-1
>            Reporter: Steven Dolg
>            Assignee: Steven Dolg
>            Priority: Critical
>             Fix For: 3.0.0-alpha-2
>
>         Attachments: parametercachekey.patch
>
>
> The equals() and hashcode() implementations of the ParameterCacheKey do *not* take the
actual parameters into account.
> This makes it possible that different pipeline setups have the same cache key and overwrite
their cached results.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message