cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Pieber (JIRA)" <j...@apache.org>
Subject [jira] Updated: (COCOON3-19) [PATCH] stax-sax converter
Date Wed, 04 Feb 2009 07:57:59 GMT

     [ https://issues.apache.org/jira/browse/COCOON3-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andreas Pieber updated COCOON3-19:
----------------------------------

    Attachment: cocoon-stax-license.patch

There are some classes which have no license in the original code... Namely:

org.apache.cocoon.stax.converter.util.XMLFilterImplEx
org.apache.cocoon.stax.converter.util.StaticNamespaceContext
org.apache.cocoon.stax.converter.util.DummyLocator

What should I do with them? At the moment I did not modify the license there at all and let
the sun-header added by you.

Further more I documented where I taken the classes from. I did this in javadoc:

/**
 * SAX ContentHandler that writes events to a StAX {@link XMLEventConsumer}.
 * 
 * @author Christian Niles
 * @version $Revision: 1.5 $
 * 
 * @version from stax-utils stable version stax-utils-20070216
 * @original javanet.staxutils.StAXEventContentHandler, javanet.staxutils.StAXContentHandler
 * @modified true (added SAXConsumer and made one class out of StAXEventContentHandler and
StAXContentHandler)
 */
public class StAXEventContentHandler extends DefaultHandler implements SAXConsumer {

or would it better to make them inline?

/**
 * SAX ContentHandler that writes events to a StAX {@link XMLEventConsumer}.
 * 
 * @author Christian Niles
 * @version $Revision: 1.5 $
 */
public class StAXEventContentHandler extends DefaultHandler implements SAXConsumer {
/*
* @version from stax-utils stable version stax-utils-20070216
* @original javanet.staxutils.StAXEventContentHandler, javanet.staxutils.StAXContentHandler
* @modified true (added SAXConsumer and made one class out of StAXEventContentHandler and
StAXContentHandler)
*/

> [PATCH] stax-sax converter
> --------------------------
>
>                 Key: COCOON3-19
>                 URL: https://issues.apache.org/jira/browse/COCOON3-19
>             Project: Cocoon 3
>          Issue Type: Sub-task
>          Components: cocoon-stax
>            Reporter: Andreas Pieber
>            Assignee: Reinhard Poetz
>         Attachments: cocoon-stax-license.patch, cocooon-stax-converter.patch
>
>
> We experimented with wrappers to add SAX-components to StAX pipelines and with Adapters
between StAX pipelines and SAX pipelines. IMO they work quite fine :)
> The problem with this patch is that it relies on the stax-utils project. Most classes
in o.a.c.stax.converter.util are redistrubuted from the stax-utils (https://stax-utils.dev.java.net/)
project. This was required since there's an architectural issue so that stax-utils can not
be used directly as reference. I posted at the stax-utils dev mailing list two weeks ago,
if they could make some of their methods protected instead of private so that we could resolve
this issue, but I did not receive an answer. 
> I created a seperated issue for this problem since there's the opened question of how
to mark the redistributed classes from the stax-utils project. I think Reinhard know ways
of how to resolve this problem :)
> I created this issue as an subtask of COCOON3-18 since first the patch of COCOON3-18
have to be applied before this patch could be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message