cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grzegorz Kossakowski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COCOON3-14) Use generics for pipeline assembly
Date Sat, 24 Jan 2009 12:55:59 GMT

    [ https://issues.apache.org/jira/browse/COCOON3-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666913#action_12666913
] 

Grzegorz Kossakowski commented on COCOON3-14:
---------------------------------------------

> As far as I understood all the discussions it is now allowed to mix sax with stax or
dom components in a pipeline, 
> they are required to use the eventing (if you regard dom as one single big event).

Is this event-based communication guaranteed at PipelineComponent level or it's left to implementation
how to design it?

> If a user knows which type of components (s)he will use, the pipeline can be "narrowed
down" to accept only those type of components.
> If the exact type is not known or a mixture of different components is to be used, using


How it's possible that user is using a component and does not know what kind of input/output
this component deals with?

I agree with Steven's point on the need for creation of marker interfaces. If they are going
to be purely marker interfaces then I'm quite concerned about this solution.

Is it only my omission or this patch does not solve a problem with Pipeline results outlined
by Reinhard: http://article.gmane.org/gmane.text.xml.cocoon.devel/79362

To sum up my opinion I'm -0 on this patch. In itself it's not bad (and not invading) but I
think this patch tries to tweak broken foundations. I would prefer if we could agree on Pipelines
and PipelineComponent fundamental design decisions and goals before we move to providing patches.

There were two different approaches presented in form of patches that left on or another side
unhappy so such an agreement seems to be the best solution. What about a serious discussion
on this topic during ApacheCon EU this year? I don't want to suspend the whole discussion
for two months, of course.

> Use generics for pipeline assembly
> ----------------------------------
>
>                 Key: COCOON3-14
>                 URL: https://issues.apache.org/jira/browse/COCOON3-14
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-pipeline
>            Reporter: Carsten Ziegeler
>            Assignee: Cocoon Developers Team
>         Attachments: generics.patch
>
>
> This is a simple patch to add generics to the pipeline interface and impl. With additionally
introducing marker interfaces for the component types (SAX, Stax, dom)
> this would allow compile time checks if all components have the correct type when assembling
the pipeline.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message