Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 63258 invoked from network); 15 Dec 2008 10:59:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Dec 2008 10:59:44 -0000 Received: (qmail 18142 invoked by uid 500); 15 Dec 2008 10:59:56 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 18081 invoked by uid 500); 15 Dec 2008 10:59:56 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 18072 invoked by uid 99); 15 Dec 2008 10:59:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Dec 2008 02:59:56 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of lingererhuang@hotmail.com designates 65.54.246.211 as permitted sender) Received: from [65.54.246.211] (HELO bay0-omc3-s11.bay0.hotmail.com) (65.54.246.211) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Dec 2008 10:59:41 +0000 Received: from hotmail.com ([65.55.136.18]) by bay0-omc3-s11.bay0.hotmail.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 15 Dec 2008 02:59:20 -0800 Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC; Mon, 15 Dec 2008 02:59:20 -0800 Message-ID: Received: from 58.62.25.8 by BAY131-DAV8.phx.gbl with DAV; Mon, 15 Dec 2008 10:59:18 +0000 X-Originating-IP: [58.62.25.8] X-Originating-Email: [lingererhuang@hotmail.com] X-Sender: lingererhuang@hotmail.com From: "lingerer huang" To: Subject: Re: Very early 2.1.12-dojo1_1-dev committed Date: Mon, 15 Dec 2008 18:59:18 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AclepCz6v/1eLYNiRSmkZC4EeXBslA== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-OriginalArrivalTime: 15 Dec 2008 10:59:20.0629 (UTC) FILETIME=[2E9A6E50:01C95EA4] X-Virus-Checked: Checked by ClamAV on apache.org Hi,Jeremy I'm still waiting for your new commit. But I will give some advise for your new commit. 1.cocoon.forms.Select must implement setValue and getValue function or dojo 1.2 's new attribute style function. When I put cocoon form in dialog. the missing getValue function make the dialog miss the widget value. 2.I think the help mark and required mark don't need to add in the widget class like cocoom.forms.Select. Cause when I want to custom the error message or move the required mark from left to right ,I must modify the js source .In early version I just modified the style file then all is done. 3.You should apply the patch I send to dev-mail list earlier, cause the encoding problem will affect the multivalue widget 4.cocoon.forms.Select using .dijitComboBox style to display. But the default dijitComboBox class make the combobox fixed width. When in IE or chrome and the cocoon.forms.Select in a dijit.Dialog box, if the option is long, it looks really ugly. Regards Roy Huang