Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 9214 invoked from network); 3 Sep 2008 21:37:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Sep 2008 21:37:36 -0000 Received: (qmail 30210 invoked by uid 500); 3 Sep 2008 21:37:34 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 29823 invoked by uid 500); 3 Sep 2008 21:37:33 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 29812 invoked by uid 99); 3 Sep 2008 21:37:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2008 14:37:33 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of joerg.heinicke@gmx.de designates 213.165.64.20 as permitted sender) Received: from [213.165.64.20] (HELO mail.gmx.net) (213.165.64.20) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 03 Sep 2008 21:36:34 +0000 Received: (qmail invoked by alias); 03 Sep 2008 21:37:03 -0000 Received: from stgt-5d84ba2d.pool.einsundeins.de (EHLO [192.168.178.20]) [93.132.186.45] by mail.gmx.net (mp007) with SMTP; 03 Sep 2008 23:37:03 +0200 X-Authenticated: #3483660 X-Provags-ID: V01U2FsdGVkX1+lsfp5quSlkXTiRFfVHrKLyEd+xIdsMCIdHuTNxK 0fyAEngsbk3z7s Message-ID: <48BF0383.9090701@gmx.de> Date: Wed, 03 Sep 2008 23:37:07 +0200 From: Joerg Heinicke User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.15) Gecko/20080621 SeaMonkey/1.1.10 MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: Bug in ContinuationManagerImpl References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.53 X-Virus-Checked: Checked by ClamAV on apache.org On 03.09.2008 21:25, Gabriel Gruber wrote: > just discovered an exception inside our freshly migrated cocoon 2.2 > migration, thrown by the ContinuationManagerImpl: > > Exception in thread "Timer-0" java.util.ConcurrentModificationException > at java.util.HashMap$HashIterator.nextEntry(Unknown Source) > at java.util.HashMap$ValueIterator.next(Unknown Source) > at > org.apache.cocoon.components.flow.ContinuationsManagerImpl.invalidateContinuations( > ContinuationsManagerImpl.java:390) > at > org.apache.cocoon.components.flow.ContinuationsManagerImpl$WebContinuationsHolder.valueUnbound( > ContinuationsManagerImpl.java:548) > at > org.mortbay.jetty.servlet.AbstractSessionManager$Session.unbindValue( > AbstractSessionManager.java:1125) > Is this a new bug, or am I doing something wrong? It's a new bug I introduced with [1]. Reviewing the changes I did I found that I "optimized" some code. :-) It's around line 390 [2]. I'll have a look on how to fix it. Sorry for the inconveniences. Joerg [1] http://svn.apache.org/viewvc?view=rev&revision=643752 [2] http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/components/flow/ContinuationsManagerImpl.java?r1=643716&r2=643752&diff_format=h