Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-Id: <E899D9DD-6098-41E9-AFE9-B09BA921E6E9@reverycodes.com>
From: Vadim Gritsenko <vadim@reverycodes.com>
To: dev@cocoon.apache.org
In-Reply-To: <1219390515.19104.48.camel@thorsten-desktop>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v926)
Subject: Re: [2.1] AbstractCachingProcessingPipeline and cocoon CLI
Date: Fri, 22 Aug 2008 08:18:58 -0400
References: <1219321083.19104.8.camel@thorsten-desktop>
 <A5B87FC7-78F9-4CCA-B1D7-5C1F7251A1D8@reverycodes.com>
 <1219390515.19104.48.camel@thorsten-desktop>

On Aug 22, 2008, at 3:35 AM, Thorsten Scherler wrote:

> How about:
>                 } else {
> -                    Object lock =
> env.getObjectModel().get(HttpEnvironment.HTTP_REQUEST_OBJECT);
> +                    Object lock =
> env.getObjectModel().get(ObjectModelHelper.REQUEST_OBJECT);
>                     try {
>                         transientStore.store(lockKey, lock);
>                     } catch (IOException e) {
>
> This way we always lock the same object.

Exactly this thing I was trying to explain - it will not work because  
instead of using top level request you are suggesting to use current  
sub-request.

Take a look at EnvironmentWrapper (which is used e.g. in SitemapSource):

         // create new object model and replace the request object
         Map oldObjectModel = env.getObjectModel();
         if (oldObjectModel instanceof HashMap) {
             this.objectModel = (Map)((HashMap)oldObjectModel).clone();
         } else {
             this.objectModel = new HashMap(oldObjectModel.size()*2);
             Iterator entries = oldObjectModel.entrySet().iterator();
             Map.Entry entry;
             while (entries.hasNext()) {
                 entry = (Map.Entry)entries.next();
                 this.objectModel.put(entry.getKey(), entry.getValue());
             }
         }
         this.request = new  
RequestWrapper(ObjectModelHelper.getRequest(oldObjectModel),
                                           requestURI,
                                           queryString,
                                           this,
                                           rawMode);
         this.objectModel.put(ObjectModelHelper.REQUEST_OBJECT,  
this.request);


Vadim