Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 18522 invoked from network); 21 Aug 2008 17:39:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 Aug 2008 17:39:25 -0000 Received: (qmail 65526 invoked by uid 500); 21 Aug 2008 17:39:16 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 65444 invoked by uid 500); 21 Aug 2008 17:39:15 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 65330 invoked by uid 99); 21 Aug 2008 17:39:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Aug 2008 10:39:14 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Aug 2008 17:38:15 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4F1A9234C1C5 for ; Thu, 21 Aug 2008 10:38:44 -0700 (PDT) Message-ID: <1939829454.1219340324323.JavaMail.jira@brutus> Date: Thu, 21 Aug 2008 10:38:44 -0700 (PDT) From: "Christoph Gaffga (JIRA)" To: dev@cocoon.apache.org Subject: [jira] Commented: (COCOON-2216) IncludeCacheManager can not perfom parallel includes In-Reply-To: <1612542401.1215085245338.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COCOON-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624430#action_12624430 ] Christoph Gaffga commented on COCOON-2216: ------------------------------------------ I'm curious on the solution of this bug also. And do you know what, we had the same problem with multi-threading and parallel processing with cocoon 2.1 when it came out. As I remember Carsten Ziegeler fixed the component manager then. So I was surprised that the same issue was introduced again into 2.2. Seems nobody is really using parallel aggregation, so never tested. But it's a great feature for content aggregation! > IncludeCacheManager can not perfom parallel includes > ---------------------------------------------------- > > Key: COCOON-2216 > URL: https://issues.apache.org/jira/browse/COCOON-2216 > Project: Cocoon > Issue Type: Bug > Components: - Components: Sitemap > Affects Versions: 2.2-dev (Current SVN) > Reporter: Christoph Gaffga > Assignee: Grzegorz Kossakowski > Attachments: cocoon-trunk.patch, ParallelInclusionProblem-cocoon_TRUNK.patch, test-block.zip, test-webapp.zip > > > Since we migrated from cocoon 2.1 to 2.2 a generator that merges multiple sources from other cocoon pipelines into one (similar to the aggregator) is not working anymore. > We also posted our problem to the mailing list, got little feedback but it brought us on the right way... > see also: http://www.mail-archive.com/users@cocoon.apache.org/msg42173.html > I found out that it's a problem with the DefaultIncludeCacheManager, that can not do parallel inclusion of cocoon-pipelines anymore. I checked several classes where inclusion is used. In the aggregator parallel inclusion is not an option anymore, in CIncludeTransformer the IncludeCacheManager is used, but it can't do parallel inclusion. In the new IncludeTransfomer parallel inclusion is supported, but it does not use caching as it does not use the IncludeCacheManager... > But we needed caching AND parallel processing, so I tried to find out what's broken in the DefaultIncludeCacheManager: > and it seems that the ThreadLocal variables are not initialized for the child threads that do the inclusion. Neither the spring context nor the old environment stuff was initialized. And all the source resolving was done outside the child thread and that way using the wrong thread context. > We were able to fix that issue by small changes to DefaultIncludeCacheManager and IncludeCacheManagerSession. It would be great if somebody could apply this patch so we don'T have to patch every cocoon version again and again... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.