Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 23310 invoked from network); 22 Jul 2008 00:05:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Jul 2008 00:05:04 -0000 Received: (qmail 87006 invoked by uid 500); 22 Jul 2008 00:05:03 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 86932 invoked by uid 500); 22 Jul 2008 00:05:03 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 86921 invoked by uid 99); 22 Jul 2008 00:05:03 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Jul 2008 17:05:03 -0700 X-ASF-Spam-Status: No, hits=-1998.5 required=10.0 tests=ALL_TRUSTED,WEIRD_PORT X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jul 2008 00:04:06 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B040A234C172 for ; Mon, 21 Jul 2008 17:04:31 -0700 (PDT) Message-ID: <271846190.1216685071718.JavaMail.jira@brutus> Date: Mon, 21 Jul 2008 17:04:31 -0700 (PDT) From: "imran pariyani (JIRA)" To: dev@cocoon.apache.org Subject: [jira] Commented: (COCOON-2216) IncludeCacheManager can not perfom parallel includes In-Reply-To: <1612542401.1215085245338.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COCOON-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615481#action_12615481 ] imran pariyani commented on COCOON-2216: ---------------------------------------- have attached the test case to reproduce the error .. i have attached three files .. test-block is the main block .. webapp is for running that block .. before that u will have to apply the patch cocoon-trunk.patch to the cocoon other wise it wont work at all ... for both the block perform mvn install .. and then for from inside the webapp block mvn jetty:run so the page http://localhost:8888/test-block/index.html is generated using the parallel generator .. if ur lucky and dont get the error the first time then just refresh and am sure the error will be there .. there are five components included in that page ... out of which 4 are normal jx components and the fifth one is cforms component ... all the jx component have been assigned different instance of the same object but still the properties displayed on the page shows the same value(they should be different) .. if u execute query for these components individually then they appear without any error .. links for querying them individually [jx components .. shows xml output .. forgot to add the pipeline to serialize it to html.. u can add one] http://localhost:8888/test-block/showjx http://localhost:8888/test-block/showjx1 http://localhost:8888/test-block/showjx2 http://localhost:8888/test-block/showjx3 [cforms component] http://localhost:8888/test-block/form2bean.flow most of the time we get the error Caused by: org.apache.commons.jxpath.JXPathException: No value for xpath: $cocoon/continuation/id its because the objectmodel is being changed by all the components simultaneously ...the error is there in the log file not on the page .. on the page it will just ignore that component > IncludeCacheManager can not perfom parallel includes > ---------------------------------------------------- > > Key: COCOON-2216 > URL: https://issues.apache.org/jira/browse/COCOON-2216 > Project: Cocoon > Issue Type: Bug > Components: - Components: Sitemap > Affects Versions: 2.2-dev (Current SVN) > Reporter: Christoph Gaffga > Attachments: cocoon-trunk.patch, ParallelInclusionProblem-cocoon_TRUNK.patch, test-block.zip, test-webapp.zip > > > Since we migrated from cocoon 2.1 to 2.2 a generator that merges multiple sources from other cocoon pipelines into one (similar to the aggregator) is not working anymore. > We also posted our problem to the mailing list, got little feedback but it brought us on the right way... > see also: http://www.mail-archive.com/users@cocoon.apache.org/msg42173.html > I found out that it's a problem with the DefaultIncludeCacheManager, that can not do parallel inclusion of cocoon-pipelines anymore. I checked several classes where inclusion is used. In the aggregator parallel inclusion is not an option anymore, in CIncludeTransformer the IncludeCacheManager is used, but it can't do parallel inclusion. In the new IncludeTransfomer parallel inclusion is supported, but it does not use caching as it does not use the IncludeCacheManager... > But we needed caching AND parallel processing, so I tried to find out what's broken in the DefaultIncludeCacheManager: > and it seems that the ThreadLocal variables are not initialized for the child threads that do the inclusion. Neither the spring context nor the old environment stuff was initialized. And all the source resolving was done outside the child thread and that way using the wrong thread context. > We were able to fix that issue by small changes to DefaultIncludeCacheManager and IncludeCacheManagerSession. It would be great if somebody could apply this patch so we don'T have to patch every cocoon version again and again... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.