Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 81795 invoked from network); 2 Apr 2008 02:04:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Apr 2008 02:04:32 -0000 Received: (qmail 79996 invoked by uid 500); 2 Apr 2008 02:04:31 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 79928 invoked by uid 500); 2 Apr 2008 02:04:31 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 79917 invoked by uid 99); 2 Apr 2008 02:04:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Apr 2008 19:04:31 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of joerg.heinicke@gmx.de designates 213.165.64.20 as permitted sender) Received: from [213.165.64.20] (HELO mail.gmx.net) (213.165.64.20) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 02 Apr 2008 02:03:49 +0000 Received: (qmail invoked by alias); 02 Apr 2008 02:03:59 -0000 Received: from c-76-116-243-84.hsd1.pa.comcast.net (EHLO c-76-116-243-84.hsd1.pa.comcast.net) [76.116.243.84] by mail.gmx.net (mp041) with SMTP; 02 Apr 2008 04:03:59 +0200 X-Authenticated: #3483660 X-Provags-ID: V01U2FsdGVkX18b7BUT+k0bdINikaM7HQV0d3YnC5q7QZOxk24j+J HtsWgD2GLyZf9L Message-ID: <47F2E98D.1040402@gmx.de> Date: Tue, 01 Apr 2008 22:03:57 -0400 From: Joerg Heinicke User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.12) Gecko/20080201 SeaMonkey/1.1.8 MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: svn commit: r643293 - /cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/components/flow/WebContinuationDataBean.java References: <20080401061737.74CB11A9832@eris.apache.org> <5AAE5D2E-26F9-44D9-8A02-0335612B9399@reverycodes.com> In-Reply-To: <5AAE5D2E-26F9-44D9-8A02-0335612B9399@reverycodes.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Virus-Checked: Checked by ClamAV on apache.org On 01.04.2008 08:02, Vadim Gritsenko wrote: >> fix threading issue (DateFormat is not thread-safe) >> >> public String getLastAccessTime() { >> - return formatter.format(new Date(wc.getLastAccessTime())); >> + synchronized (this.formatter) { >> + return formatter.format(new Date(wc.getLastAccessTime())); >> + } >> } > > The better fix is to use FastDateFormat which features thread safe > formatting. All these nice little gems hidden in Apache Commons libs :) Applied. Thanks, Joerg