cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kamal Bhatt (JIRA)" <j...@apache.org>
Subject [jira] Created: (COCOON-2204) [PATCH]
Date Sun, 27 Apr 2008 12:12:55 GMT
[PATCH] 
--------

                 Key: COCOON-2204
                 URL: https://issues.apache.org/jira/browse/COCOON-2204
             Project: Cocoon
          Issue Type: Bug
          Components: Blocks: Forms
    Affects Versions: 2.2, 2.2-dev (Current SVN)
            Reporter: Kamal Bhatt
             Fix For: 2.2-dev (Current SVN)


According to this page: http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html

If you you are using Ajax, a div (or similar element) must surround the fields of a group.
eg:

<ft:group id="info">
  <div>
    <p><ft:widget id="foo"/></p>
    <p><ft:widget id="bar"/></p>
  </div>
</ft:group>

CForms (through the magic of the forms-field-styling.xsl) will put the group's id on the div.
The code to this, seems broken as it does not match on the div, but on the fi:group.

NOTE: This is another solution to the problem described here:

https://issues.apache.org/jira/browse/COCOON-1825

However, the solution described within it seems to make the suggestion in http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html
redundant. Either way, either this issue or that one is not necessary. 

Patch is provided below:

Index: D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
===================================================================
--- D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
(revision 651922)
+++ D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
(working copy)
@@ -706,7 +706,7 @@
     <xsl:apply-templates/>
   </xsl:template>
 
-  <xsl:template match="fi:group" mode="copy-parent-id">
+  <xsl:template match="*" mode="copy-parent-id">
     <xsl:copy>
       <xsl:attribute name="id"><xsl:value-of select="../@id"/></xsl:attribute>
       <xsl:copy-of select="@*"/>



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message