Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 3885 invoked from network); 11 Mar 2008 21:03:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 Mar 2008 21:03:07 -0000 Received: (qmail 45890 invoked by uid 500); 11 Mar 2008 21:03:02 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 45836 invoked by uid 500); 11 Mar 2008 21:03:02 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 45825 invoked by uid 99); 11 Mar 2008 21:03:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Mar 2008 14:03:02 -0700 X-ASF-Spam-Status: No, hits=-1.0 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of grek@tuffmail.com designates 216.86.168.178 as permitted sender) Received: from [216.86.168.178] (HELO mxout-03.mxes.net) (216.86.168.178) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Mar 2008 21:02:24 +0000 Received: from [192.168.0.195] (unknown [212.76.37.214]) by smtp.mxes.net (Postfix) with ESMTP id 3E7EC23E458 for ; Tue, 11 Mar 2008 17:02:34 -0400 (EDT) Message-ID: <47D7020F.6030906@tuffmail.com> Date: Tue, 11 Mar 2008 23:05:03 +0100 From: Grzegorz Kossakowski User-Agent: Thunderbird 2.0.0.9 (X11/20070801) MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: svn commit: r635881 - /cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/spring/ServletFactoryBean.java References: <20080311105852.01AA01A9832@eris.apache.org> In-Reply-To: <20080311105852.01AA01A9832@eris.apache.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org reinhard@apache.org pisze: > Author: reinhard > Date: Tue Mar 11 03:58:38 2008 > New Revision: 635881 > > URL: http://svn.apache.org/viewvc?rev=635881&view=rev > Log: > the context attribute might not exist > [...] > + if(contextPath != null) { > + int tmp = contextPath.indexOf(':'); > + boolean tmp2 = !(contextPath.startsWith("file:") || contextPath.startsWith("/") || contextPath.indexOf(':') == -1); This is not a solution IMHO. I forgot to bring this issue to mailing list, my fault. Actually, I think we should disallow empty context-path and mount-path attributes because there is no sane way to handle such cases. If you don't set contextPath, then you break a contract in ServletContext class because getResource() method no longer works. I think we should just change our schema and throw an exception when any of attributes is null. WDYT? -- Grzegorz Kossakowski