cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reinhard Poetz <reinh...@apache.org>
Subject [ssf] context path
Date Wed, 12 Mar 2008 07:22:32 GMT
Grzegorz Kossakowski wrote:
> reinhard@apache.org pisze:
>> Author: reinhard
>> Date: Tue Mar 11 03:58:38 2008
>> New Revision: 635881
>>
>> URL: http://svn.apache.org/viewvc?rev=635881&view=rev
>> Log:
>> the context attribute might not exist
>>
> [...]
> 
>> +        if(contextPath != null) {
>> +            int tmp = contextPath.indexOf(':');
>> +            boolean tmp2 = !(contextPath.startsWith("file:") || contextPath.startsWith("/")
|| contextPath.indexOf(':') == -1);
> 
> This is not a solution IMHO. I forgot to bring this issue to mailing list, my fault.
Actually, I
> think we should disallow empty context-path and mount-path attributes because there is
no sane way
> to handle such cases. If you don't set contextPath, then you break a contract in ServletContext
> class because getResource() method no longer works.
> 
> I think we should just change our schema and throw an exception when any of attributes
is null.

after thinking about it again, it makes sense to me.

-- 
Reinhard Pötz                            Managing Director, {Indoqa} GmbH
                           http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member, PMC Chair        reinhard@apache.org
_________________________________________________________________________

Mime
View raw message