cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Knecht (JIRA)" <>
Subject [jira] Commented: (COCOON-2168) ResourceReader produces Java Heap Overflow when reading a huge resource
Date Thu, 06 Mar 2008 09:26:57 GMT


Felix Knecht commented on COCOON-2168:

I agree with Joerg that my patch is against the idea of buffering the whole pipeline. OTH
 (looking at security issues) I think it can be dangerous to accept Overflows by using a default
configuration - I don't know how Java behaves in this case.

That's why I'd prefer another default value than -1 if none is configured (no matter if it's
8192 or 1024^2). But I think it should be a value which doesn't causes the application to
fail when run with default settings and using large resource files.

> ResourceReader produces Java Heap Overflow when reading a huge resource
> -----------------------------------------------------------------------
>                 Key: COCOON-2168
>                 URL:
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Felix Knecht
>         Attachments: ResourceReader.diff, test-case.tar.gz
> When reading a huge resource (i.e. 700MB file) the ResourceReader produces an overflow
due to the BufferedOutputStream which is used (and forced to be used via AbstractReader).
The BufferedOutputStream flushes only at the end (or when forced to), but overwrites the flush
method to do nothing.
> As I don't know exactly where the BufferedOutputStream is used and what kind of impacts
it will have to change it there I'm just going to fix the ResourceReader.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message