From dev-return-98483-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org Thu Feb 21 08:39:52 2008 Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 58345 invoked from network); 21 Feb 2008 08:39:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 Feb 2008 08:39:51 -0000 Received: (qmail 19597 invoked by uid 500); 21 Feb 2008 08:39:45 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 19520 invoked by uid 500); 21 Feb 2008 08:39:45 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 19509 invoked by uid 99); 21 Feb 2008 08:39:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Feb 2008 00:39:45 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 21 Feb 2008 08:39:07 +0000 Received: (qmail 58257 invoked from network); 21 Feb 2008 08:39:26 -0000 Received: from localhost (HELO carsten-ziegelers-computer.local) (127.0.0.1) by localhost with SMTP; 21 Feb 2008 08:39:26 -0000 Message-ID: <47BD38BD.60403@apache.org> Date: Thu, 21 Feb 2008 09:39:25 +0100 From: Carsten Ziegeler User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; de; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: PipelineEvents eat children References: <47BCC87F.7030600@gmx.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org solprovider@apache.org wrote > > The fix is one short function added to > PipelineEventComponentProcessingNode and called in the line that sets > the Parameters of the three child classes. Maintenance would be easy. > No, it is not - fixing it this way would cause a lot of trouble and break the whole sitemap engine. The current sitemap has been drafted way back in the early days of Cocoon more than eight years ago. One basic concept is that selectors and matchers only define which components are used in the pipeline processing. They've never meant to be used for configuration selection of a single component. This has been discussed for Cocoon 2.0 and it has been this way for the whole time. During all these years this has never been a problem for Cocoon users as it is a very clear concept. Inside selectors you can have any other component like matchers, transformers, you name it. So if we follow your suggestion we have two different kind of selectors. Which will end in handling special cases and special case handling is always bad. Starting to allow selectors for choosing configuration parameters will end in a very very messy and not maintainable sitemap, so Joergs suggestions are a much better way of handling things. Just you can do something without Java coding does not mean that this is the best and cleanest way. Carsten -- Carsten Ziegeler cziegeler@apache.org