From dev-return-98445-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org Tue Feb 12 12:59:38 2008 Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 16718 invoked from network); 12 Feb 2008 12:59:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Feb 2008 12:59:38 -0000 Received: (qmail 77610 invoked by uid 500); 12 Feb 2008 12:59:31 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 77275 invoked by uid 500); 12 Feb 2008 12:59:30 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 77264 invoked by uid 99); 12 Feb 2008 12:59:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2008 04:59:30 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Feb 2008 12:58:59 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A328B714066 for ; Tue, 12 Feb 2008 04:59:07 -0800 (PST) Message-ID: <3003082.1202821147663.JavaMail.jira@brutus> Date: Tue, 12 Feb 2008 04:59:07 -0800 (PST) From: =?utf-8?Q?J=C3=B6rg_Heinicke_=28JIRA=29?= To: dev@cocoon.apache.org Subject: [jira] Updated: (COCOON-2167) Default value of validate attribute of submit widget has changed from true to false In-Reply-To: <5184846.1202777827846.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COCOON-2167?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] J=C3=B6rg Heinicke updated COCOON-2167: ---------------------------------- Status: Continued (was: On Hold) http://marc.info/?l=3Dxml-cocoon-dev&m=3D120281571604587&w=3D4 I took SubmitDefinitionBuilder but not SubmitDefinition, which obviously wa= s the problem. so behavior is consistent in 2.2 and 2.1.12, but was simply = my "backporting" which introduced the bug. > Default value of validate attribute of submit widget has changed from tru= e to false > -------------------------------------------------------------------------= ---------- > > Key: COCOON-2167 > URL: https://issues.apache.org/jira/browse/COCOON-2167 > Project: Cocoon > Issue Type: Bug > Components: Blocks: Forms > Affects Versions: 2.1.11 > Reporter: J=C3=B6rg Heinicke > Assignee: J=C3=B6rg Heinicke > > http://marc.info/?l=3Dxml-cocoon-dev&m=3D120277341318228&w=3D4 > Hello > I noticed a change in behavior of cforms lately. the submit widget now= =20 > has "false" as default value for the "validate" attribute (opposed to the= =20 > documenation which says, true is the default value). This really breaks= =20 > our application. After backporting vadim's fixes for the concurrency bug= s=20 > we discovered to cforms 2.1.10, we also "migrated" this new behavior to= =20 > our cforms version. > here is the code, which has an extra if statement in comparision to=20 > 2.1.10. > public final class SubmitDefinitionBuilder extends ActionDefinitionBuilde= r=20 > { > public WidgetDefinition buildWidgetDefinition(Element widgetElement, = WidgetDefinitionBuilderContext context) > throws Exception { > SubmitDefinition definition =3D new SubmitDefinition(); > setupDefinition(widgetElement, definition, context); > // parse "@validate" > if (widgetElement.hasAttribute("validate")) { > definition.setValidateForm(DomHelper.getAttributeAsBoolean(wi= dgetElement, "validate", true)); > } > definition.makeImmutable(); > return definition; > } > } > Is there any reason, why the behavior was changed and if it was a=20 > accident, could someone revert the code inside the repos to the old=20 > behavior? > thanx alot! > Gabriel --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.