Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Mime-Version: 1.0 (Apple Message framework v753)
In-Reply-To: <45A2FB44-C0A2-4C7A-A0B3-C3BFB41E2128@robinwyles.com>
References: <954B4833-CB1E-4EB8-BF30-6B5DA3203244@robinwyles.com>
 <477B9C8C.6060906@tuffmail.com>
 <16500C7C-BE58-4C15-8857-A00AF8F3BBAB@robinwyles.com>
 <477DA1F8.5020307@gmx.de>
 <45A2FB44-C0A2-4C7A-A0B3-C3BFB41E2128@robinwyles.com>
Content-Type: multipart/signed; micalg=sha1; boundary=Apple-Mail-1-803839600;
 protocol="application/pkcs7-signature"
Message-Id: <FB2631A7-AF7B-4E81-A35C-0823B287C45C@robinwyles.com>
From: Robin Wyles <rob@robinwyles.com>
Subject: Re: Repository block and C2.2
Date: Mon, 14 Jan 2008 10:10:55 +0100
To: dev@cocoon.apache.org


--Apple-Mail-1-803839600
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	delsp=yes;
	format=flowed

Hi...

On 5 Jan 2008, at 13:18, Robin Wyles wrote:

>
> On 4 Jan 2008, at 04:03, Joerg Heinicke wrote:
>
>> On 02.01.2008 11:26 Uhr, Robin Wyles wrote:
>>
>>> Looking at the pom I don't see any version numbers, but the  
>>> dependencies seem to be:
>>> cocoon-core
>>> cocoon-eventcache-impl
>>> excalibur-datasource
>>> servlet-api
>>
>> From what I know in this case these versions are in the parent  
>> POM. And all these dependencies should be releases. You might need  
>> to convert cocoon-eventcache-impl first though - or get rid of the  
>> dependency. It was always quite big dependency tree for repository  
>> block if I remember correctly. See 2.1 blocks.properties [1].
>
> The dependency on cocoon-eventcache-impl is from  
> SimpleJdbcSourceDescriptor [1] which itself needs cocoon-database- 
> impl if it is to be used [2]. As you say the dependency tree is  
> quite large, and the following may be tricky...
>
> cocoon-repository-impl -> cocoon-eventcache-impl -> cocoon-jms-impl  
> -> cocoon-cron-impl
>
> ... as cocoon-cron-impl is apparently deprecated. I haven't looked  
> into cocoon-jms-impl to see where the dependencies on cocoon-cron- 
> impl are, so I'm not sure what the best course of action is here,  
> any advice would be welcome.


After looking a bit deeper into this I can't see why the following  
dependencies exist:

  cocoon-eventcache-impl -> cocoon-jms-impl

cocoon-jms-impl -> cocoon-cron-impl

Removing these dependencies from the block POMs doesn't cause any  
build errors. Could someone with more knowledge of the eventcache and  
jms blocks tell me if these dependencies are still valid?


Thanks,

Robin

>
>>
>>>> For final I would like to see some samples (repository block  
>>>> lacks any) and at least minimal coverage by tests.
>>
>> Grek is really pushing hard for getting better test coverage :)
>
> Well, if you aim for the stars you might reach the moon :)
>
>>
>>> Me too, after going through your points below my plan is to write  
>>> initial tests for SourceRepository to test all repository  
>>> operations using a local file:// based repository.
>>> Ultimately I would like to see this block springified (sprung?)  
>>> too - I envisage us creating our own Repository implementations  
>>> and would much prefer to do this using Spring.
>>
>> I wonder if we are going the same way as for forms block: 1.0 for  
>> the 2.2-converted block, 1.1 for the next step, the  
>> springification. This means we should do this migration in 2 steps.
>
> Agreed.
>
>>
>>>> I think that the best strategy would be to create configuration  
>>>> of sitemap components in order to
>>>> get them running then try to run rest of components.
>>> Will do this and set up some tests for these components - I'm  
>>> still figuring out how some of the other components in this block  
>>> are used and so how they can be tested.
>>>> I guess it's not that much work left in order to prepare first  
>>>> milestone release of repository block
>>>> but having even few samples would be highly appreciated.
>>> I'll report back after I've taken a look at the above and will  
>>> hopefully have an idea of what the samples could contain.
>>
>> Maybe it does not make much sense to have samples for this block,  
>> especially if it does only provide basic functionality. I don't  
>> know the scope of the repository block though. But maybe it's up  
>> to blocks like webdav to provide the actual samples. The test  
>> coverage is probably more important.
>
> There are a couple of sitemap components,  
> TraversableSourceDescriptionGenerator and  
> SourcePropsWritingTransformer, that could be used for samples.  
> Although the latter needs a suitable SourceDescriptor - the only  
> one present is SimpleJdbcSourceDescriptor which has the dependency  
> issues outlined above.
>
> I'm not quite sure how tests for SourcePropsWritingTransformer can  
> be written though - used in conjunction with  
> SimpleJdbcSourceDescriptor it will need a test database.
>
> I think SourceRepository might also be worthy of a sample - this  
> could be wrapped around a FileSource repository and show basic  
> manipulation of repository content. I'll certainly be writing tests  
> for this component as it's the one which will be using first. If  
> anyone more familiar with the repository block can provide more  
> info on what else should be covered by tests then please let me know.
>
> Robin
>
> [1] http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon- 
> repository/cocoon-repository-impl/src/main/java/org/apache/cocoon/ 
> components/source/impl/SimpleJdbcSourceDescriptor.java? 
> revision=587761&view=markup
>
> [2] http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon- 
> repository/cocoon-repository-impl/src/main/resources/META-INF/ 
> cocoon/avalon/cocoon-repository.xconf?revision=588098&view=markup
>
>
>>
>> Joerg
>>
>> [1] http://svn.apache.org/viewvc/cocoon/branches/BRANCH_2_1_X/ 
>> blocks.properties?revision=488038&view=markup
>>
>
>
>


--Apple-Mail-1-803839600
Content-Transfer-Encoding: base64
Content-Type: application/pkcs7-signature;
	name=smime.p7s
Content-Disposition: attachment;
	filename=smime.p7s

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGJTCCAt4w
ggJHoAMCAQICEAJwCPkbN36Jeo9Jt7RpTgIwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx
JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ
ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA3MDkxNjE3MTA0OFoXDTA4MDkxNTE3MTA0
OFowRDEfMB0GA1UEAxMWVGhhd3RlIEZyZWVtYWlsIE1lbWJlcjEhMB8GCSqGSIb3DQEJARYScm9i
QHJvYmlud3lsZXMuY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAufz8LA3dNZxj
uh6biqGZ0CE5OaHiDuxFEdjN4BxGFJsm/9GgYjLTFi6pRos1+iKL3TUnq6IbA2aHifPGowMT09ir
W7FXf2KjERBh4TFVW9AGB47BWtTOOzuZOE8kBGGS69jzw8XpVaXR4EtZm8Skgpio1G2g3uVNY3nW
tUGD2aBzSHCBsKG3q/C9480ckaNtqPAt+mMNlYJSw7i3Ed5/JHjsoN1/UQnMebpWZmp5J/WQSEpq
FvdQvW8trRhoRm9uGZ6/z+/0K2eW2FPOwQm6FL6m+jJHI3yPJe+MGSl8HCwIcl8JoqURGatmX/de
+xFzLIlEvFSlidsCiURYi37iywIDAQABoy8wLTAdBgNVHREEFjAUgRJyb2JAcm9iaW53eWxlcy5j
b20wDAYDVR0TAQH/BAIwADANBgkqhkiG9w0BAQUFAAOBgQAoSsrhlMnaVhNdRzUhQ3h1xB+rKYY4
zC5pJnPyHzb6GhvoHUQl8M5P5gdMFoFWjuw7JZ3cnPo1mAAnJRyZ0frgFlJfwsmDcU+v70wI4kO4
ZLI5iwVPgaaYp7oE0iRapx3707+9oE1UQx0ZauALGu9nI/UjMnRl1PAWKcL+8UfypjCCAz8wggKo
oAMCAQICAQ0wDQYJKoZIhvcNAQEFBQAwgdExCzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0ZXJu
IENhcGUxEjAQBgNVBAcTCUNhcGUgVG93bjEaMBgGA1UEChMRVGhhd3RlIENvbnN1bHRpbmcxKDAm
BgNVBAsTH0NlcnRpZmljYXRpb24gU2VydmljZXMgRGl2aXNpb24xJDAiBgNVBAMTG1RoYXd0ZSBQ
ZXJzb25hbCBGcmVlbWFpbCBDQTErMCkGCSqGSIb3DQEJARYccGVyc29uYWwtZnJlZW1haWxAdGhh
d3RlLmNvbTAeFw0wMzA3MTcwMDAwMDBaFw0xMzA3MTYyMzU5NTlaMGIxCzAJBgNVBAYTAlpBMSUw
IwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVy
c29uYWwgRnJlZW1haWwgSXNzdWluZyBDQTCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEAxKY8
VXNV+065yplaHmjAdQRwnd/p/6Me7L3N9VvyGna9fww6YfK/Uc4B1OVQCjDXAmNaLIkVcI7dyfAr
hVqqP3FWy688Cwfn8R+RNiQqE88r1fOCdz0Dviv+uxg+B79AgAJk16emu59l0cUqVIUPSAR/p7bR
PGEEQB5kGXJgt/sCAwEAAaOBlDCBkTASBgNVHRMBAf8ECDAGAQH/AgEAMEMGA1UdHwQ8MDowOKA2
oDSGMmh0dHA6Ly9jcmwudGhhd3RlLmNvbS9UaGF3dGVQZXJzb25hbEZyZWVtYWlsQ0EuY3JsMAsG
A1UdDwQEAwIBBjApBgNVHREEIjAgpB4wHDEaMBgGA1UEAxMRUHJpdmF0ZUxhYmVsMi0xMzgwDQYJ
KoZIhvcNAQEFBQADgYEASIzRUIPqCy7MDaNmrGcPf6+svsIXoUOWlJ1/TCG4+DYfqi2fNi/A9BxQ
IJNwPP2t4WFiw9k6GX6EsZkbAMUaC4J0niVQlGLH2ydxVyWN3amcOY6MIE9lX5Xa9/eH1sYITq72
6jTlEBpbNU1341YheILcIRk13iSx0x1G/11fZU8xggMQMIIDDAIBATB2MGIxCzAJBgNVBAYTAlpB
MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg
UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQAnAI+Rs3fol6j0m3tGlOAjAJBgUrDgMCGgUA
oIIBbzAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0wODAxMTQwOTEw
NTVaMCMGCSqGSIb3DQEJBDEWBBQdCUe8mDfjf3HRJPSUIsl9enFz8zCBhQYJKwYBBAGCNxAEMXgw
djBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEs
MCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIElzc3VpbmcgQ0ECEAJwCPkbN36Jeo9J
t7RpTgIwgYcGCyqGSIb3DQEJEAILMXigdjBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3Rl
IENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWls
IElzc3VpbmcgQ0ECEAJwCPkbN36Jeo9Jt7RpTgIwDQYJKoZIhvcNAQEBBQAEggEAhMo9mO/FkDAk
o0N5CecwbsaVyVd8cf8HJuVHSfl8QOnHbO/HjhMJMTP0njR+yr1j1P3V4/zw1NvsIsSY1ZB3pKBz
qwL1om+lf0pL+/9CFqi0sMM8llu+QajlxWKY62P7PHCz40zg5pkmJIVe86D34PuHXDbU/5Cqbv/C
xuVW9B2DLqTagruMl8zfrg3GT7MHN/rMJC1V5PuIl+X17doKUPtP4XwAenmQO13Ih2aT6zL6d5zu
poJRJzf4b2hXn+boXX0OvWs5tqb2cZZ72W7jfLwOxBA2hs5l3yc0ygZG3lc+0EzKyrva+KYrTZtV
WXXHEb+98iqufHUW721loMg/0AAAAAAAAA==

--Apple-Mail-1-803839600--