Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <478CF0C0.6070506@apache.org>
Date: Tue, 15 Jan 2008 18:43:28 +0100
From: Reinhard Poetz <reinhard@apache.org>
User-Agent: Thunderbird 2.0.0.9 (Windows/20071031)
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: Integration tests
References: <20080115011932.2C5941A9832@eris.apache.org>
 <478C0C12.6020901@apache.org> <478C4EB3.3040102@apache.org>
 <478C7A2A.10806@apache.org>
In-Reply-To: <478C7A2A.10806@apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Grzegorz Kossakowski wrote:
> Reinhard Poetz pisze:
>> Grzegorz Kossakowski wrote:
>>> gkossakowski@apache.org pisze:
>>> 
>>> I'm not sure how to say this but... Guys, there is a lot of to cover by
>>> test in this module and writing tests in trunk is not painful by any
>>> means.
>> you are right and this particular bug was my fault because I haven't 
>> written any tests yet. However, if you followed my commit messages, you saw
>> that I was able to enable integration tests for trunk ('mvn install -P it'
>> from cocoon-webapp runs the tests in cocoon-webapp/src/test/java). My next 
>> step on my todo list is covering the SSF with tests.
> 
> Yes I was very happy to see your commits. However, I always thought that it's
> first that you write unit tests for covering the most basic functionality and
> ITs for testing how different parts interact with each other.
> 
> Doesn't it make sense to write a few unit tests first? 

:-) yes, I fully agree. However, I wanted to explore the code by writing unit 
tests but I failed. Maybe I invested to less time but I came to the conclustion 
that it is easier to write integration tests.

> What kind of ITs do you plan to write?

I want to test ...
  o absolute and relative connections to servlet services
  o connecting to blocks using the servlet:/ protocol
  o super connections
  o accessing information coming from the original request
  o error handling
  o postable sources
  o servlet-service generator/transformer/serializer

>> Could somebody with admin rights on vmbuild help me with adding the 
>> integration tests to Continuum?
> 
> Sure, tell what command exactly is needed to be fired. Is mvn clean install
> -P allbocks,it enough?

yes

-- 
Reinhard Pötz                            Managing Director, {Indoqa} GmbH
                           http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member, PMC Chair        reinhard@apache.org
_________________________________________________________________________