Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Message-ID: <25134241.1200443854867.JavaMail.jira@brutus>
Date: Tue, 15 Jan 2008 16:37:34 -0800 (PST)
From: =?utf-8?Q?J=C3=B6rg_Heinicke_=28JIRA=29?= <jira@apache.org>
To: dev@cocoon.apache.org
Subject: [jira] Commented: (COCOON-2162) [PATCH] Fix for Paginator when
 accessing out of bounds Pagination page
In-Reply-To: <2656369.1200418175255.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/COCOON-2162?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D125=
59305#action_12559305 ]=20

J=C3=B6rg Heinicke commented on COCOON-2162:
---------------------------------------

Instead of a 404 I would rather send the last page if the requested page nu=
mber is greater than the last page number and the first page if it is less =
than the first page 0 or 1 (depends on whether index is 0 or 1-based).

> [PATCH] Fix for Paginator when accessing out of bounds Pagination page
> ----------------------------------------------------------------------
>
>                 Key: COCOON-2162
>                 URL: https://issues.apache.org/jira/browse/COCOON-2162
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: Blocks: (Undefined)
>    Affects Versions: 2.1.10, 2.1.11
>            Reporter: Drew Buschhorn
>            Priority: Minor
>         Attachments: paginator.diff, screenshot-1.jpg
>
>
> The Paginator transformer for apache cocoon will allow out of page-range =
requests.
> I've added the below logic-test into my own copy of cocoon, and that seem=
s to fix the problem.
> Please let me know if you think 1. this is valid and 2. that it should be=
 placed into svn for the 2.1.x version of cocoon.
> Example:
> http://localhost/samples/paginator/text(5)
> will return a valid empty file before patch (despite there being only 4 p=
ages worth of data to paginate)
> after patch, returns ResourceNotFound/404.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.