cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Drew Buschhorn (JIRA)" <>
Subject [jira] Commented: (COCOON-2162) [PATCH] Fix for Paginator when accessing out of bounds Pagination page
Date Wed, 16 Jan 2008 01:01:34 GMT


Drew Buschhorn commented on COCOON-2162:

Thought about that, but I have two objections:

1.  Generally back-ends should be no smarter than necessary: asking for a page that is beyond
the created pages should throw an error (not be silently corrected) esp. since one could 
catch the 404 error in the sitemap and load the last page.

2.  I'm not smart enough to know how to access the number of pages created by the paginator
outside of the java-class, so I dont know how to find out how many pages it will create without
asking it for the largest page that doesnt throw a 404 error.


tried setting it to catch things <0, but that throws a indexOutOfBounds java error that
I didnt feel like learning how to catch.

> [PATCH] Fix for Paginator when accessing out of bounds Pagination page
> ----------------------------------------------------------------------
>                 Key: COCOON-2162
>                 URL:
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: Blocks: (Undefined)
>    Affects Versions: 2.1.10, 2.1.11
>            Reporter: Drew Buschhorn
>            Priority: Minor
>         Attachments: paginator.diff, screenshot-1.jpg
> The Paginator transformer for apache cocoon will allow out of page-range requests.
> I've added the below logic-test into my own copy of cocoon, and that seems to fix the
> Please let me know if you think 1. this is valid and 2. that it should be placed into
svn for the 2.1.x version of cocoon.
> Example:
> http://localhost/samples/paginator/text(5)
> will return a valid empty file before patch (despite there being only 4 pages worth of
data to paginate)
> after patch, returns ResourceNotFound/404.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message