cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reinhard Poetz <reinh...@apache.org>
Subject Re: Is throwing exception always good choice?
Date Mon, 28 Jan 2008 14:12:18 GMT
Felix Knecht wrote:
> Grzegorz Kossakowski schrieb:
>> Hello guys,
>>
>> I noticed comment from Dominic Mitchell at his blog complaining[1] 
>> about the fact that we print 30
>> lines long exception just to inform there is no block handling 
>> favicon.ico browser's request.
>>
>> It is caused by following snippet in DispatcherServlet:
>>
>>         if (servlet == null) {
>>             throw new ServletException("No block for " + 
>> req.getPathInfo());
>>         }
>>
>> Now I start to think that throwing this exception is a bad idea. It's 
>> going to be quite casual
>> situation that server is requested non-existing resources and I think 
>> we shouldn't do so much noise
>> about it. Why about just returning 404 response with message the same 
>> as it's now thrown within
>> exception?
>>
>> I'll make this change within two days if nobody complains.
>>   
> +1.
> 
> Can we log the error instead? IMO it may help whenever you need to track 
> problems only having the log files.

yes, good idea (but please don't use ERROR or even higher as log level -> INFO 
should be good enough)

-- 
Reinhard Pötz                            Managing Director, {Indoqa} GmbH
                           http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member, PMC Chair        reinhard@apache.org
_________________________________________________________________________

Mime
View raw message