cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robin Wyles (JIRA)" <>
Subject [jira] Updated: (COCOON-2133) Addition of "allow-enlarge" parameter to ImageOp resize operation
Date Thu, 03 Jan 2008 12:47:34 GMT


Robin Wyles updated COCOON-2133:

    Attachment: 4x2.jpg

Grzegorz, thanks for your test case patches!

Attached is patch for "allow-enlarge" parameter along with a suitable test case.

Writing the tests I uncovered some strange behavior with allow-enlarge parameter when used
with preserve-ratio. It seems that before my patches the ResizeOperation would fail to enlarge
an image at all when preserve-ratio was set to true and only one dimension was supplied. This
final patch fixes this issue, using allow-enlarge parameter to control first whether image
should be resized and then preserve-ratio to determine final size.

I also include my test image separately as well - for me at least images often seem to corrupt
when supplied as part of a patch.

> Addition of "allow-enlarge" parameter to ImageOp resize operation
> -----------------------------------------------------------------
>                 Key: COCOON-2133
>                 URL:
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: Blocks: ImageOp
>    Affects Versions: 2.1.11, 2.2-dev (Current SVN)
>            Reporter: Robin Wyles
>            Priority: Minor
>         Attachments: 4x2.jpg, cocoon-core-SitemapComponentTestCase-read-method.patch,
cocoon-imageop-impl-no-effects-test.patch, cocoon-imageop-impl-resize-operation-and-test.patch
, ResizeOperation.patch, RevisedResizeOperationPatch.txt
> The addition of an "allow-enlarge" parameter to the resize operation allows the user
to control whether an image should be enlarged by the operation. 
> This new  parameter is declared in the sitemap like so:
> <map:read type="imageop" src="image.jpg">
> 	<map:parameter name="prefix-preserve-ratio" value="true"/>
> 	<map:parameter name="prefix-allow-enlarge" value="false"/>
> 	<map:parameter name="prefix-width" value="320"/>
> 	<map:parameter name="prefix-height" value="240"/>
> </map:read>

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message