cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Heinicke (JIRA) <j...@apache.org>
Subject [jira] Commented: (COCOON-2162) [PATCH] Fix for Paginator when accessing out of bounds Pagination page
Date Wed, 16 Jan 2008 00:37:34 GMT

    [ https://issues.apache.org/jira/browse/COCOON-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559305#action_12559305
] 

Jörg Heinicke commented on COCOON-2162:
---------------------------------------

Instead of a 404 I would rather send the last page if the requested page number is greater
than the last page number and the first page if it is less than the first page 0 or 1 (depends
on whether index is 0 or 1-based).

> [PATCH] Fix for Paginator when accessing out of bounds Pagination page
> ----------------------------------------------------------------------
>
>                 Key: COCOON-2162
>                 URL: https://issues.apache.org/jira/browse/COCOON-2162
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: Blocks: (Undefined)
>    Affects Versions: 2.1.10, 2.1.11
>            Reporter: Drew Buschhorn
>            Priority: Minor
>         Attachments: paginator.diff, screenshot-1.jpg
>
>
> The Paginator transformer for apache cocoon will allow out of page-range requests.
> I've added the below logic-test into my own copy of cocoon, and that seems to fix the
problem.
> Please let me know if you think 1. this is valid and 2. that it should be placed into
svn for the 2.1.x version of cocoon.
> Example:
> http://localhost/samples/paginator/text(5)
> will return a valid empty file before patch (despite there being only 4 pages worth of
data to paginate)
> after patch, returns ResourceNotFound/404.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message