Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 79593 invoked from network); 24 Dec 2007 16:48:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 24 Dec 2007 16:48:09 -0000 Received: (qmail 81261 invoked by uid 500); 24 Dec 2007 16:47:57 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 81035 invoked by uid 500); 24 Dec 2007 16:47:56 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 81024 invoked by uid 99); 24 Dec 2007 16:47:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Dec 2007 08:47:56 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [66.51.199.25] (HELO mail1.dslextreme.com) (66.51.199.25) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 24 Dec 2007 16:47:32 +0000 Received: (qmail 21412 invoked from network); 24 Dec 2007 16:47:36 -0000 Received: from unknown (HELO [127.0.0.1]) (66.51.196.164) by mail1.dslextreme.com with (RC4-MD5 encrypted) SMTP; Mon, 24 Dec 2007 08:47:36 -0800 Message-ID: <476FE2A7.9080101@dslextreme.com> Date: Mon, 24 Dec 2007 08:47:35 -0800 From: Ralph Goers Reply-To: rgoers@apache.org User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: JXPathHelper References: <476F67D2.8060109@dslextreme.com> <476F7647.2090204@tuffmail.com> <476F7B3D.4030608@dslextreme.com> <476F7C64.7090800@dslextreme.com> <476FC74C.9020901@tuffmail.com> <476FDBA8.9060008@dslextreme.com> In-Reply-To: <476FDBA8.9060008@dslextreme.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org http://marc.info/?l=xml-cocoon-dev&m=108266407019215&w=2 Ralph Goers wrote: > So you have no problem breaking API contracts with end users on minor > point releases? > > Grzegorz Kossakowski wrote: >> Ralph Goers pisze: >> >>> I have verified that the code below gets my new XPathXMLFileModule >>> working again. However, I'm still not sure that is the correct thing to >>> do as the change essentially broke the contract. So although I could >>> make the same change in all the affected Cocoon classes any customer >>> who >>> happened to use JXPathHelper for their own purposes would also have >>> problems. >>> >> >> I agree that fix for COCOON-2108 changed the contract but I don't >> agree it broke as I think it's >> been broken earlier. Issue COCOON-2108 was caused by the fact that >> getAttribute was doing something >> completely unexpected. Instead of returning an Object it returns >> String representation of Object. >> That's bad situation and if someone relies on bad API it's also his >> business to fix his code. >> >> I think the best is to introduce new method like getAttributeAsString >> and switch to it everywhere >> it's needed. >> >>