cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reinhard Poetz <reinh...@apache.org>
Subject Re: svn commit: r607723 - /cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletRequest.java
Date Mon, 31 Dec 2007 14:05:58 GMT
Grzegorz Kossakowski wrote:
> reinhard@apache.org pisze:
>> Author: reinhard Date: Mon Dec 31 03:02:53 2007 New Revision: 607723
>> 
>> URL: http://svn.apache.org/viewvc?rev=607723&view=rev Log: COCOON-1831 Pass
>> data from the parent request to the child request. This time session
>> handling is also included and lookup of enumerations is fixed (mostly based
>> on Rice's patch). Before closing this issue I will change the code to use
>> the parent request only instead of iterating the whole call stack to lookup
>> values
>> 
> 
> [...]
> 
>> 
>> +    private ServletServiceContext context; +
> 
> Is there any reason to hold reference to ServletServiceContext apart from the
> fact that getRequestDispatcher() implementatio needs it?

The getSession(...) method uses it too.

>> -    /* -     * (non-Javadoc) -     * -     * @see
>> javax.servlet.ServletRequest#getProtocol() -     */ public String
>> getProtocol() { return PROTOCOL; }
> 
> Was there any good reason for removing these comments?

What are they good for? It doesn't produce content for the Javadocs and a modern
IDE makes it easy to jump to the interface. What do I miss?

-- 
Reinhard Pötz                            Managing Director, {Indoqa} GmbH
                           http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member, PMC Chair        reinhard@apache.org
_________________________________________________________________________

Mime
View raw message