cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grzegorz Kossakowski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COCOON-1831) Passing parameters to sub calls
Date Sat, 29 Dec 2007 01:39:43 GMT

    [ https://issues.apache.org/jira/browse/COCOON-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554870
] 

Grzegorz Kossakowski commented on COCOON-1831:
----------------------------------------------

> But 'parentRequest' used in the code seems a little weird, my original version callingRequest
or just caller might be better because we 
> might get confused with the parent used in block inheritance. 

Agreed.

> By the way, in the above post it is stated that there is some controversial discussion
in applying the idea used in this patch on session. What is it? 

Have a look at this thread:
http://thread.gmane.org/gmane.text.xml.cocoon.cvs/25924/focus=76076

It's best to read whole discussion because lots of great thoughts has been presented.

> After a more detail look at the code, I think that iteration over call stack is necessary
in implementing getValues() and getNames() method.
> For Object getValue(String name), recursive call is enough. But for getting all values
or all names for the whole values in the calling chain, 
> iterating each call frame to collect their values is necessary. However, by implementing
these 2 methods (getValues() and getNames()), 
> then there is no such thing as values hiding.

Could you explain in detail why it's needed for getValues()? Why approach outlined in my above
comment won't work?

> Also I find some bug in my previous patch. So I have the new implementation attached
for reference.

Could you be more specific? What bug you have discovered?

> Passing parameters to sub calls
> -------------------------------
>
>                 Key: COCOON-1831
>                 URL: https://issues.apache.org/jira/browse/COCOON-1831
>             Project: Cocoon
>          Issue Type: New Feature
>          Components: - Servlet service framework
>            Reporter: Reinhard Poetz
>            Assignee: Reinhard Poetz
>         Attachments: BlockCallHttpServletRequest.patch, cocoon-servlet-service-impl.patch,
cocoon-servlet-service-impl.patch
>
>
> When a servlet service request is created, parameters from the parent request are ignored.
This means that the sub request is performed as a fresh and clean new call. This would avoid
any possible side-effects, but is very inconvenient in practice because you don't even know
the request header parameters from the original (external) request. Additionally you can only
pass information which is part of the returned stream, which is e.g. a  blocker to use the
servlet protocol together with the control flow implementations. Those make use of special
request parameters to transport the model ("bizdata") to the view layer. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message