cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grzegorz Kossakowski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COCOON-2155) Failing test cases due to additional attributes from namespace declarations in a DOM from parser, but not from serializer
Date Fri, 28 Dec 2007 11:49:43 GMT

    [ https://issues.apache.org/jira/browse/COCOON-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554680
] 

Grzegorz Kossakowski commented on COCOON-2155:
----------------------------------------------

Thanks Joerg for reviewing my patches. I won't attach fixed patches but your suggestion must
be taken into account when patches are applied, of course.

I'm don't like these superfluous declarations either but my opinion is that test-cases should
always reflect in every detail behaviour of components they test. Current behaviour of tested
components is to leave superfluous namespace declarations and this must be reflected in tests.
If we decide to change that or not is separate case and I think we shouldn't mix them.

BTW. CIncludeTransformer removes it's own namespace declarations and leaves the rest so in
this case I had to add namespace declaration to cinclude-input-* files because they are expected
in the output files.

> Failing test cases due to additional attributes from namespace declarations in a DOM
from parser, but not from serializer
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: COCOON-2155
>                 URL: https://issues.apache.org/jira/browse/COCOON-2155
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Grzegorz Kossakowski
>         Attachments: COCOON-2155-cocoon-core.patch, COCOON-2155-cocoon-forms-impl.patch,
COCOON-2155-cocoon-template-impl.patch, COCOON-2155-parent-pom.patch
>
>
> Quoting Joerg:
> "Just an explanation: A namespace declaration is not an attribute (even 
> if it looks so) and that's why it should not end as such. The DOM 
> produced by Cocoon is absolutely correct, the one by parsing expected 
> document in the test case is not since it has both the namespace 
> declaration AND an attribute xmlns:fi - which broke our test."
> (http://article.gmane.org/gmane.text.xml.cocoon.devel/75975)
> Also see this: http://article.gmane.org/gmane.text.xml.cocoon.devel/75974

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message