cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grzegorz Kossakowski (JIRA)" <>
Subject [jira] Updated: (COCOON-2126) CForms-Ajax-Update sends <span> instead of <td>
Date Mon, 24 Dec 2007 00:59:43 GMT


Grzegorz Kossakowski updated COCOON-2126:

    Affects version (Component): Parent values: Blocks: Forms(10167). Level 1 values: 1.0.0-RC1(10321).

This issue affects Forms 1.0.0-RC1 (and earlier) also.

I found out why it sends <span> tag instead of <td>. It's done that way because
<span> tag was chosen as a general placeholder for inactive/hidden widgets. It's wrong
for two reasons:
1. Widget is a block-level element so <div> (used as container for block-level elements)
should be used instead of <span> which is used as container for inline elements.
2. Widget can behave as a table cell which is counter-intuitive behaviour on its own but when
<span> is used as placeholder it simply blows up.

The fix will probably consist of special treatment of the case when hidden widget is a whole
RepeaterRow. I have some ideas how to fix this issue but I need to dig further into rendering
guts of Forms to see if my ideas are generic enough.

What's more I'm going to fix trunk first and only then port the fix back to 2.1.x branch.
It's caused by the fact that I lost ability to work effectively with 2.1.x. Compared with
2.2 it looks sooo much painful and inconvenient to do anything non-trivial...

> CForms-Ajax-Update sends <span> instead of <td>
> -----------------------------------------------
>                 Key: COCOON-2126
>                 URL:
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Ajax, Blocks: Forms
>    Affects Versions: 2.1.10
>            Reporter: Florian Weitling
>            Assignee: Grzegorz Kossakowski
>         Attachments: screenshot-1.jpg, screenshot-2.jpg, screenshot-3.jpg, showQuestion.bind.xml,
showQuestion.def.xml, showQuestion.js, showQuestion.tmpl.xml, sitemap-excerpt.xmap
> In a <table> the cells' entries are delivered by a repeater. When hiding a cell
programmatically via WidgetState.INVISIBLE the bu:update contains a <span> instead of
a <tr> or another hint to hide away the cell. This results in weird optics 'cause <span>
is not allowed as child of a <tr>.
> My current workaround: Using <div>s with table* styles.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message