cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alfred Nathaniel (JIRA)" <>
Subject [jira] Commented: (COCOON-1990) Redirect bug WITHIN sub sitemap WHEN using uri-prefix in map:mount
Date Sat, 08 Dec 2007 12:47:43 GMT


Alfred Nathaniel commented on COCOON-1990:

Vadim, sub-sitemap and root sitemap can be in the same directory.  Only, before I put my hands
on the code, cocoon:/ could not be used in the sub-sitemap (it would be interpreted as cocoon://).

I am not completely sure that the latest version with the explicit check for cocoon:// works,
because there may be additional effects due to the MutableEnvironmentFacade case.  If that
turns out to be the case, I propose to revert to the original version, which has been working
for years, except for the recently discovered corner case.

Jörg, I agree, that the hardwired "cocoon://" check is not the most appealing solution. 
But given the facts that 2.1 is in maintenance mode, 2.2 already has a completely different
code in that area, and people are discussion a deprecation of the cocoon; protocol, I am pragmatic
and don't think it is worthwhile to invest much more effort on this.  I only would want to
have a working solution in 2.1.11.

Of course, if you feel like it, you are welcome to do it better.

> Redirect bug WITHIN sub sitemap WHEN using uri-prefix in map:mount
> ------------------------------------------------------------------
>                 Key: COCOON-1990
>                 URL:
>             Project: Cocoon
>          Issue Type: Bug
>          Components: * Cocoon Core
>    Affects Versions: 2.1.10
>            Reporter: Robert Hoffmann
>            Assignee: Alfred Nathaniel
>             Fix For: 2.1.11-dev (Current SVN)
> Hi cocoon developers,
> I found the following problem with redirects within sub-sitemaps WHEN using the uri-prefix
in map:mount...
> Test case:
> 1) Sitemaps:
> Root sitemap >>
> ...
> <map:pipeline>
>    <map:match pattern="test/**">
>      <map:mount check-reload="yes" src="subsitemap.xmap" uri-prefix="test" /> 
> </map:pipeline>
> ...<<
> Sub sitemap >>
> ...
>  <map:match pattern="A.html">
>   <map:redirect-to uri="cocoon:/B.html"/>
>  </map:match>
>  <map:match pattern="B.html">
>   <map:redirect-to uri=""/>
>  </map:match>
> ...<<
> 2) NOW: When you request "http://testserver/cocoon/test/A.html"...
> you should get redirected to B.html WITHIN the sub sitemap (that's why we use 'cocoon:/B.html'
and not 'cocoon://B.html')...
> BUT the redirect does NOT work correctly, hence we will not get the google-site which
would be the correct result.
> 3) The cocoon.log says: http-11080-Processor23/CocoonServlet: No pipeline matched request:
test/B.html !!!
> [So it seems to me that the uri-prefix from the sub-sitemap mount is added in the this
redirect, which might be why it does not match then within the sub-sitemap.]
> 3) Important: This only goes wrong when using the uri-prefix[-remove] attribute in map:mount
> I hope this detailed test case will be helpful to one of the cocoon gurus... I really
would hate if I had to use redirects to the ROOT sitemap (that's not the idea of sub sitemaps).
> Many thanks!!!
> Robert
> PS: Cocoon really rocks!
> --
> Have you tried iHOP yet?

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message