From dev-return-97377-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org Sat Nov 03 15:29:04 2007 Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 96489 invoked from network); 3 Nov 2007 15:29:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Nov 2007 15:29:04 -0000 Received: (qmail 48606 invoked by uid 500); 3 Nov 2007 15:28:51 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 48520 invoked by uid 500); 3 Nov 2007 15:28:51 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 48508 invoked by uid 99); 3 Nov 2007 15:28:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Nov 2007 08:28:51 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of joerg.heinicke@gmx.de designates 213.165.64.20 as permitted sender) Received: from [213.165.64.20] (HELO mail.gmx.net) (213.165.64.20) by apache.org (qpsmtpd/0.29) with SMTP; Sat, 03 Nov 2007 15:28:51 +0000 Received: (qmail invoked by alias); 03 Nov 2007 15:28:22 -0000 Received: from c-69-139-17-253.hsd1.pa.comcast.net (EHLO c-69-139-17-253.hsd1.pa.comcast.net) [69.139.17.253] by mail.gmx.net (mp057) with SMTP; 03 Nov 2007 16:28:22 +0100 X-Authenticated: #3483660 X-Provags-ID: V01U2FsdGVkX18oYmtv7agoxp3hhLGiCvjXqcetKTEliuJHy1gdKx 54NA3cXDfCjZDv Message-ID: <472C9394.8030902@gmx.de> Date: Sat, 03 Nov 2007 11:28:20 -0400 From: Joerg Heinicke User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.8) Gecko/20071008 SeaMonkey/1.1.5 MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: svn commit: r591599 - /cocoon/trunk/core/cocoon-core/src/main/java/org/apache/cocoon/servlet/multipart/MultipartParser.java References: <20071103113014.30A9B1A9832@eris.apache.org> In-Reply-To: <20071103113014.30A9B1A9832@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-Virus-Checked: Checked by ClamAV on apache.org On 03.11.2007 7:30 Uhr, felixk@apache.org wrote: > Author: felixk > Date: Sat Nov 3 04:30:13 2007 > New Revision: 591599 > > URL: http://svn.apache.org/viewvc?rev=591599&view=rev > Log: > Method invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead > > Creating new instances of java.lang.Boolean wastes memory, since Boolean objects are immutable and there are only two useful values of this type. Use the Boolean.valueOf() method (or Java 1.5 autoboxing) to create Boolean objects instead. Even better should be the usage of the constants Boolean.FALSE and Boolean.TRUE since the exact values are known beforehand. Joerg