cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Grzegorz Kossakowski <gkossakow...@apache.org>
Subject Re: svn commit: r599593 - /cocoon/trunk/core/cocoon-servlet-service/cocoon-servlet-service-impl/src/main/java/org/apache/cocoon/servletservice/util/BlockCallHttpServletRequest.java
Date Fri, 30 Nov 2007 21:55:38 GMT
Reinhard Poetz pisze:
> Grzegorz Kossakowski wrote:
>> reinhard@apache.org pisze:
>>
>> Hi Reinhard,
>>
>> I would like to ask how your changes relate to
>> https://issues.apache.org/jira/browse/COCOON-1831 ?
> 
> I was searching for this patch but didn't find it because it is a
> sub-task in Jira. Looking now at it, I see that Rice' implementation
> goes further than what I did and my implementation is skipping request
> parameters passed as querystring which is definitly an error. I'm going
> to fix this ASAP.
> 
> BTW, do you know why it is necessary to traverse the call stack? Why
> isn't it good enough to use the values from the calling request?

Hmmm, I haven't spotted fragments traversing calling stack earlier. I'll investigate more
tomorrow
and I'll try to figure out if its really needed (my gut feeling is it's not needed).

>> Also, are you planning to add test-cases for this functionality? It
>> would be highly recommended to
>> have them.
> 
> Yes, actually I'm facing some subtle problems with servlet-services,
> e.g. when exceptions occur, that make the use of servlet-services
> sometimes really painful.

What do you mean exactly?

> I will add some tests before the final release.

Great, thanks!

-- 
Grzegorz Kossakowski
Committer and PMC Member of Apache Cocoon
http://reflectingonthevicissitudes.wordpress.com/

Mime
View raw message