cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Heinicke <joerg.heini...@gmx.de>
Subject Re: svn commit: r597440 - /cocoon/trunk/core/cocoon-configuration/cocoon-configuration-api/src/main/java/org/apache/cocoon/configuration/PropertyHelper.java
Date Thu, 22 Nov 2007 23:31:57 GMT
On 22.11.2007 10:49 Uhr, giacomo@apache.org wrote:
> Author: giacomo
> Date: Thu Nov 22 07:49:00 2007
> New Revision: 597440
> 
> URL: http://svn.apache.org/viewvc?rev=597440&view=rev
> Log:
> fixing NPE
> 
> Modified:
>     cocoon/trunk/core/cocoon-configuration/cocoon-configuration-api/src/main/java/org/apache/cocoon/configuration/PropertyHelper.java
> 
> Modified: cocoon/trunk/core/cocoon-configuration/cocoon-configuration-api/src/main/java/org/apache/cocoon/configuration/PropertyHelper.java
> URL: http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-configuration/cocoon-configuration-api/src/main/java/org/apache/cocoon/configuration/PropertyHelper.java?rev=597440&r1=597439&r2=597440&view=diff
> ==============================================================================
> --- cocoon/trunk/core/cocoon-configuration/cocoon-configuration-api/src/main/java/org/apache/cocoon/configuration/PropertyHelper.java
(original)
> +++ cocoon/trunk/core/cocoon-configuration/cocoon-configuration-api/src/main/java/org/apache/cocoon/configuration/PropertyHelper.java
Thu Nov 22 07:49:00 2007
> @@ -159,8 +159,10 @@
>             String value = props.getProperty(key);
>             // replace
>             value = replace(value, props, settings);
> -           // and put back
> -           props.put(key, value);
> +           // and put back but prevent NPE because of null value ?!?!?
> +           // TODO: How to handle value==null situations?
> +           if (value != null)
> +               props.put(key, value);
>         }
>      }
>  }

How can this be null after all? From what I see value can only be null 
if value was null in the first place, i.e. before replace(..). This 
means that null must already have been in the Properties object which is 
kind of impossible since Properties.put(..) inherited from HashTable 
throws NPE on value being null.

Where do you have this Properties object from which is only injected by 
the user into AbstractSettingsBeanFactoryPostProcessor?

Joerg

Mime
View raw message