From dev-return-96602-apmail-cocoon-dev-archive=cocoon.apache.org@cocoon.apache.org Sun Sep 02 09:28:45 2007 Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 16630 invoked from network); 2 Sep 2007 09:28:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Sep 2007 09:28:41 -0000 Received: (qmail 97112 invoked by uid 500); 2 Sep 2007 09:28:35 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 97032 invoked by uid 500); 2 Sep 2007 09:28:35 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 97021 invoked by uid 99); 2 Sep 2007 09:28:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Sep 2007 02:28:35 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_HELO_PASS,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [216.86.168.179] (HELO mxout-04.mxes.net) (216.86.168.179) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Sep 2007 09:29:36 +0000 Received: from [192.168.0.125] (unknown [80.240.191.89]) by smtp.mxes.net (Postfix) with ESMTP id C0E72A3234 for ; Sun, 2 Sep 2007 05:28:04 -0400 (EDT) Message-ID: <46DA8227.3040106@apache.org> Date: Sun, 02 Sep 2007 11:28:07 +0200 From: Grzegorz Kossakowski User-Agent: Thunderbird 2.0.0.5 (X11/20070719) MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: True OO for servlet service References: <46D46F36.4010400@tuffmail.com> <47f71d940709012353s60cc54deu11f3083d47a9826b@mail.gmail.com> In-Reply-To: <47f71d940709012353s60cc54deu11f3083d47a9826b@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Rice Yeh pisze: > Hi Grek, Hi Rice :) > Attached is the patch that is based on the present > cocoon-servlet-service-impl implementation. cocoon-servlet-service-impl > has some change since I posted my patch on COCOON-2038, which has > already too many files attached to it. In order not to confuse you, I > have the the patch attached to this mail. So you do not need to patch > the files in COCOON-2038. There is a legal problem with such approach. When attaching patch to a JIRA issue you check the option that you intend this file for inclusion to the source codes licensed by Apache License. This agreement is a must in order to commit your patch. I already cleaned up COCOON-2038 so you can safely attach your patch as cocoon-servlet-service-impl-with-tests.patch. > I find you already have written a test case > class ServletServiceContextTestCase for ServletServiceContext. Yes and I wanted to know if testContextInServletCalledFromExplicitSuperCall covers the bug we were talking about in COCOON-2038 as I'm not sure. > I add one > more test case in it to test COCOON-1939. All the test cases in > ServletServiceContextTestCase are passed. > So after applying this patch, you might close COCOON-2038 by referring > back to this mail if there are no further problems. Great, thanks Rice for your work! As long as all doubts are dispelled I'll commit your patch. -- Grzegorz Kossakowski http://reflectingonthevicissitudes.wordpress.com/