Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 35807 invoked from network); 28 Aug 2007 18:54:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Aug 2007 18:54:30 -0000 Received: (qmail 33033 invoked by uid 500); 28 Aug 2007 18:54:17 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 32942 invoked by uid 500); 28 Aug 2007 18:54:16 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 32927 invoked by uid 99); 28 Aug 2007 18:54:16 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Aug 2007 11:54:16 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of grek@tuffmail.com designates 216.86.168.179 as permitted sender) Received: from [216.86.168.179] (HELO mxout-04.mxes.net) (216.86.168.179) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Aug 2007 18:54:08 +0000 Received: from [192.168.0.125] (unknown [80.240.191.89]) by smtp.mxes.net (Postfix) with ESMTP id 4AAE9A329B for ; Tue, 28 Aug 2007 14:53:45 -0400 (EDT) Message-ID: <46D46F36.4010400@tuffmail.com> Date: Tue, 28 Aug 2007 20:53:42 +0200 From: Grzegorz Kossakowski User-Agent: Thunderbird 2.0.0.5 (X11/20070719) MIME-Version: 1.0 To: Cocoon's dev mailing list Subject: True OO for servlet service Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Hello, I don't have that much time to spend these days on Cocoon but I would really like to see true Object Oriented approach implemented in upcoming[1] release of cocoon-servlet-service. The main task is tracked by COCOON-2038[2] where Rice Yeh has uploaded his patch implementing true OO behaviour in servlet-service-fw. According to Rice, this patch contains a bug-fix as well (details in the comments). After reviewing Rice's patch I decided that we really need test coverage for this quite complicated functionality for both ServletServiceContext class usage clarity and casual hunting for bugs. Daniel pointed me to another bug report (COCOON-1939[3]) that involves OO aspects of servlet-service-fw. That makes point about test coverage even more strong. What I would like to ask you for in this e-mail is to add additional tests to ServletServiceContextTestCase class that exhibit problems mentioned in both issues. As soon as I have working test cases I guess that fixing problems would be quite easy. Since it was you who discovered problems it should be quite easy to write tests for them, too. Alexander and Rice, can I count on your help with this before next release in late September is cut? [1] http://article.gmane.org/gmane.text.xml.cocoon.devel/74999 [2] https://issues.apache.org/jira/browse/COCOON-2038 [3] https://issues.apache.org/jira/browse/COCOON-1939 -- Grzegorz Kossakowski http://reflectingonthevicissitudes.wordpress.com/