Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 35919 invoked from network); 31 Jul 2007 20:51:33 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 31 Jul 2007 20:51:31 -0000 Received: (qmail 7755 invoked by uid 500); 31 Jul 2007 20:51:25 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 7544 invoked by uid 500); 31 Jul 2007 20:51:24 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 7456 invoked by uid 99); 31 Jul 2007 20:51:24 -0000 Received: from Unknown (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jul 2007 13:51:24 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jul 2007 20:51:13 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 380087141F1 for ; Tue, 31 Jul 2007 13:50:53 -0700 (PDT) Message-ID: <20942634.1185915053227.JavaMail.jira@brutus> Date: Tue, 31 Jul 2007 13:50:53 -0700 (PDT) From: "Andrew Cave (JIRA)" To: dev@cocoon.apache.org Subject: [jira] Updated: (COCOON-2104) [PATCH] Add base URI fixup support to XIncludeTransformer In-Reply-To: <7279712.1185915052921.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COCOON-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Cave updated COCOON-2104: -------------------------------- Attachment: baseFixup-2.2-r561499.diff Patch for trunk. > [PATCH] Add base URI fixup support to XIncludeTransformer > --------------------------------------------------------- > > Key: COCOON-2104 > URL: https://issues.apache.org/jira/browse/COCOON-2104 > Project: Cocoon > Issue Type: Bug > Components: * Cocoon Core > Affects Versions: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN) > Reporter: Andrew Cave > Priority: Minor > Fix For: 2.1.11-dev (Current SVN), 2.2-dev (Current SVN) > > Attachments: baseFixup-2.1-r561455.diff, baseFixup-2.2-r561499.diff > > > As discussed at [1], the XIncludeTransformer fails to perform the base URI fixup specified in the W3C's XInclude spec [2]. The spec says that the base URIs of elements do not change when passed through a conformant XInclude processor. Meaning, xml:base attributes must be added to the result set. The reason being that relative URIs in the included document should not break; this provides a mechanism to resolve them properly. > This patch results in the XIncludeTransformer adding xml:base attributes to top-level included elements. It does this only when the the base URI of the included element differs from the base URI of the parent element (meaning: for almost every case except where the included document is the current document). > The XIncludeTransformer's JUnit test is also updated by this patch to reflect the fact that the resulting XML file (xinclude-result-1.xml) has an xml:base attribute added. > [1] http://www.mail-archive.com/dev@cocoon.apache.org/msg52803.html > [2] http://www.w3.org/TR/xinclude/#base - The Base URI Fixup section of the W3C's XInclude specification -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.