cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Grzegorz Kossakowski <gkossakow...@apache.org>
Subject Re: svn commit: r554234 [1/2] - in /cocoon/trunk/blocks/cocoon-lucene/cocoon-lucene-impl/src: changes/ main/java/org/apache/cocoon/components/search/ main/java/org/apache/cocoon/generation/ main/java/org/apache/cocoon/samples/ main/resources/META-INF/cocoo...
Date Sun, 08 Jul 2007 10:22:38 GMT
felixk@apache.org pisze:
> Author: felixk
> Date: Sat Jul  7 11:08:56 2007
> New Revision: 554234
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=554234
> Log:
> Springify lucene block.
> 
> Added:
>     cocoon/trunk/blocks/cocoon-lucene/cocoon-lucene-impl/src/main/java/org/apache/cocoon/samples/LuceneCocoonCrawler.java
  (with props)
>     cocoon/trunk/blocks/cocoon-lucene/cocoon-lucene-impl/src/main/resources/META-INF/cocoon/spring/
>     cocoon/trunk/blocks/cocoon-lucene/cocoon-lucene-impl/src/main/resources/META-INF/cocoon/spring/cocoon-lucene.xml
  (with props)
> Removed:
>     cocoon/trunk/blocks/cocoon-lucene/cocoon-lucene-impl/src/main/resources/META-INF/cocoon/avalon/
>     cocoon/trunk/blocks/cocoon-lucene/cocoon-lucene-impl/src/main/resources/org/
> Modified:
>     cocoon/trunk/blocks/cocoon-lucene/cocoon-lucene-impl/src/changes/changes.xml
>     cocoon/trunk/blocks/cocoon-lucene/cocoon-lucene-impl/src/main/java/org/apache/cocoon/components/search/SimpleLuceneCocoonIndexerImpl.java
>     cocoon/trunk/blocks/cocoon-lucene/cocoon-lucene-impl/src/main/java/org/apache/cocoon/components/search/SimpleLuceneCocoonSearcherImpl.java
>     cocoon/trunk/blocks/cocoon-lucene/cocoon-lucene-impl/src/main/java/org/apache/cocoon/components/search/SimpleLuceneXMLIndexerImpl.java
>     cocoon/trunk/blocks/cocoon-lucene/cocoon-lucene-impl/src/main/java/org/apache/cocoon/generation/SearchGenerator.java
>     cocoon/trunk/blocks/cocoon-lucene/cocoon-lucene-impl/src/main/java/org/apache/cocoon/samples/LuceneUtil.java

<snip what="real changes and formatting mishmash"/>

Felix, first of all I'm grateful for your contributions and I'm feeling bad that I have to
bring this issue again.

I've been reading Karl Fogel's book[1] lately (thanks to Google for sending me, a SoC participant,
a free, printed copy) and I stumbled
across very interesting paragraph[2]. I would really like to take an advice of this paragraph
and revise others changes for reasons that 
Karl already outlined.

Felix, I hope that you'll remember to make my dreams about revising commits come true. :-)

[1] http://producingoss.com/
[2] http://producingoss.com/en/setting-tone.html#code-review

-- 
Grzegorz Kossakowski
http://reflectingonthevicissitudes.wordpress.com/


Mime
View raw message