cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grzegorz Kossakowski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COCOON-2078) Profiling pipelines must not implement Configurable interface as they are already Parameterizable
Date Sat, 07 Jul 2007 12:12:05 GMT

    [ https://issues.apache.org/jira/browse/COCOON-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510887
] 

Grzegorz Kossakowski commented on COCOON-2078:
----------------------------------------------

Thanks Alexander for reporting this issue and providing a patch. Unfortunately, I cannot apply
it, anyhow using Eclipse. I guess that there are too many differences between the content
in patch file and my checked out files.

The main difference is that  @version tags are not expanded with SVN Id that confuses patching
mechanisms.

Could you provide a better patch that was generated against svn checkout (so @version tags
are expanded)?

> Profiling pipelines must not implement Configurable interface as they are already Parameterizable
> -------------------------------------------------------------------------------------------------
>
>                 Key: COCOON-2078
>                 URL: https://issues.apache.org/jira/browse/COCOON-2078
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Profiler
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Alexander Klimetschek
>            Assignee: Grzegorz Kossakowski
>            Priority: Critical
>             Fix For: 2.2-dev (Current SVN)
>
>         Attachments: profiler-config-vs-param-fix.patch
>
>
> The most-recent change to both Profiling pipelines (revision 503964 in February 07) added
the configuration "sax-stream" option and this was done by additionally implementing the Configurable
interface. But as in BaseCachingProcessingPipeline (a base class) the interface Parameterizable
is already implemented, and an Avalon component can be either one or the other [1], this is
a bug. It's critical since the cache is retrieved in BaseCachingProcessingPipeline.parameterize(),
but as Configurable has precedence over Parameterizable [2], the cache will be null and a
NPE will be thrown during generation phase.
> [1] http://excalibur.apache.org/apidocs/org/apache/avalon/framework/parameters/Parameterizable.html
> [2] http://svn.apache.org/viewvc/cocoon/trunk/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/core/container/spring/avalon/AvalonBeanPostProcessor.java?view=markup,
see method postProcessBeforeInitialization()

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message