cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grzegorz Kossakowski (JIRA)" <j...@apache.org>
Subject [jira] Updated: (COCOON-2066) BlockCompletePathModule returns wrong path in scope of internal servlet call
Date Wed, 06 Jun 2007 21:30:26 GMT

     [ https://issues.apache.org/jira/browse/COCOON-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Grzegorz Kossakowski updated COCOON-2066:
-----------------------------------------

    Description: 
BlockCompletePathModule uses this construct: 
public Object getAttribute(String name, Configuration modeConf, Map objectModel) throws ConfigurationException
{ 
return ObjectModelHelper.getRequest(objectModel).getContextPath() + blockPathModule.getAttribute(name,
modeConf, objectModel); 
} 

However, when internal (service call or not) request is being made BlockCallHttpServletRequest
becomes an object represnting current request but it has no meaningful representation of getContextPath
method. 

Solution to this problem might be forwarding context path value from original request.

  was:
BlockCompletePathModule uses this construct:
public Object getAttribute(String name, Configuration modeConf, Map objectModel) throws ConfigurationException
{
	return ObjectModelHelper.getRequest(objectModel).getContextPath() + blockPathModule.getAttribute(name,
modeConf, objectModel);
}

However, when internal (service call or not) request is being made BlockCallHttpServletRequest
becomes an object represnting current request but it has no meaningful representation of getContextPath
method.

Solution to this problem might be forwarding context path value from original request.

        Urgency:   (was: Urgent)

Thanks Daniel for your comment. I'm just working on the implementation that you described
and came across some inconsistency.

In CallFrameHelper class setRequest method expects that its is a HttpServletRequest but in
PathDispatcher we have to deal with ServletRequest (a super interface to the first one mentioned).
Am I right that CallFrameHelper should be changed so it accepts ServletRequest parameter?

> BlockCompletePathModule returns wrong path in scope of internal servlet call
> ----------------------------------------------------------------------------
>
>                 Key: COCOON-2066
>                 URL: https://issues.apache.org/jira/browse/COCOON-2066
>             Project: Cocoon
>          Issue Type: Bug
>          Components: - Servlet service framework
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Grzegorz Kossakowski
>            Assignee: Grzegorz Kossakowski
>
> BlockCompletePathModule uses this construct: 
> public Object getAttribute(String name, Configuration modeConf, Map objectModel) throws
ConfigurationException { 
> return ObjectModelHelper.getRequest(objectModel).getContextPath() + blockPathModule.getAttribute(name,
modeConf, objectModel); 
> } 
> However, when internal (service call or not) request is being made BlockCallHttpServletRequest
becomes an object represnting current request but it has no meaningful representation of getContextPath
method. 
> Solution to this problem might be forwarding context path value from original request.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message