cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Fagerstrom (JIRA)" <>
Subject [jira] Commented: (COCOON-2066) BlockCompletePathModule returns wrong path in scope of internal servlet call
Date Wed, 06 Jun 2007 22:19:26 GMT


Daniel Fagerstrom commented on COCOON-2066:

Great that you are working on it.

Considering the setRequest method I think it makes sense to use HttpServletRequest as neither
Cocoon nor any other conceivable servlet based webapp will have any use for requests that
only implement ServletRequest (which among many other things lacks context and servlet paths).
So IMO it is better to down cast to the arguments to the forward method and fail as fast as
possible in the unlikely situation that the arguments doesn't implement HttpServlet[Request|Response].

> BlockCompletePathModule returns wrong path in scope of internal servlet call
> ----------------------------------------------------------------------------
>                 Key: COCOON-2066
>                 URL:
>             Project: Cocoon
>          Issue Type: Bug
>          Components: - Servlet service framework
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Grzegorz Kossakowski
>            Assignee: Grzegorz Kossakowski
> BlockCompletePathModule uses this construct: 
> public Object getAttribute(String name, Configuration modeConf, Map objectModel) throws
ConfigurationException { 
> return ObjectModelHelper.getRequest(objectModel).getContextPath() + blockPathModule.getAttribute(name,
modeConf, objectModel); 
> } 
> However, when internal (service call or not) request is being made BlockCallHttpServletRequest
becomes an object represnting current request but it has no meaningful representation of getContextPath
> Solution to this problem might be forwarding context path value from original request.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message