Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Received-SPF: pass (herse.apache.org: local policy)
Message-ID: <46487E7A.4060007@nada.kth.se>
Date: Mon, 14 May 2007 17:21:30 +0200
From: Daniel Fagerstrom <danielf@nada.kth.se>
User-Agent: Thunderbird 1.5.0.10 (Windows/20070221)
MIME-Version: 1.0
To: dev@cocoon.apache.org
Subject: Re: More problems with implementing servlet services
References: <4640A55B.8070200@tuffmail.com> <46424753.1020005@nada.kth.se>
 <4643DB37.8070009@reverycodes.com> <f21l0q$heg$1@sea.gmane.org>
 <464477AB.4010903@nada.kth.se> <46448C13.2070508@apache.org>
 <464509E6.4010406@reverycodes.com> <46458BBF.7020909@apache.org>
 <f254m0$lki$1@sea.gmane.org> <4646C241.6040103@apache.org>
 <f27tob$uf8$1@sea.gmane.org> <46477F2C.8020708@apache.org>
 <4647FE2F.80404@apache.org> <464813FE.3050807@nada.kth.se>
 <4648781E.6040607@apache.org>
In-Reply-To: <4648781E.6040607@apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reinhard Poetz skrev:
> Daniel Fagerstrom wrote:
>>> What about reversing the logic: Instead of
>>>
>>> >>> <map:match pattern="test5">
>>> >>>   <map:generate type="servletService" src="test.html">
>>> >>>     <map:parameter name="service" 
>>> value="servlet:test2:/extract-html"/>
>>> >>>   </map:generate>
>>> >>>   <map:serialize type="xml"/>
>>> >>> </map:match>
>>>
>>> we could use
>>>
>>> <map:match pattern="test5">
>>>   <map:generate type="servletService" 
>>> src="servlet:test2:/extract-html">
>>>     <map:parameter name="data" value="test.html"/>
>>>   </map:generate>
>>>   <map:serialize type="xml"/>
>>> </map:match>
>>>
>>> It doesn't make that much difference for generators, but would save 
>>> one line each for serializers and transformers.
>>>
>>> WDYT?
>> It would save a line, but especially for the generator it would 
>> obscure the function. For all other generators the src parameter is 
>> used for *reading* stream input. With your proposal the data 
>> parameter would instead get that role and the src parameter would be 
>> used as something that is a service that you post something to. I 
>> think that would be more confusing.
>>
>> Also for the servlet service transformer and serializer, "src" sound 
>> like something you read from rather than something you post to.
>
> hmm, the "src" attribute of generators desribes, what is feed into the 
> component. In the case of a servlet service generator, the output 
> stream of a servlet is used as stream input.
Rather something that is transformed to SAX output.
> The "data" parameter defines the content that is passed to the servlet 
> service. IMO that's not the starting point of the generator.
IMO it is ;)

The normal case:

Source ==[octet stream]==> Generator ==[SAX]==> ...

Servlet service generator as I see it:

Source ==[octet stream]==> Generator ==[SAX]==> ...
                              |  ^
                              v  |
                         ServletService

As you can see, the connection to the servlet service is something that 
differ from the ordinary generator usage, and because of that it is 
natural to put it in a parameter.

/Daniel