Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cocoon.apache.org
Message-ID: <33281363.1179942676577.JavaMail.jira@brutus>
Date: Wed, 23 May 2007 10:51:16 -0700 (PDT)
From: =?utf-8?Q?J=C3=B6rg_Heinicke_=28JIRA=29?= <jira@apache.org>
To: dev@cocoon.apache.org
Subject: [jira] Closed: (COCOON-1686) [PATCH] COCOON-1671 Form not binding
 when prefix in binding definition is unequal to that in the instance data
 for the same namespace.
In-Reply-To: <1703365328.1132167208325.JavaMail.jira@ajax.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/COCOON-1686?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:all-tabpanel ]

J=C3=B6rg Heinicke closed COCOON-1686.
---------------------------------

    Resolution: Won't Fix

As pointed out the patch is considered to be inappropriate.

> [PATCH] COCOON-1671 Form not binding when prefix in binding definition is=
 unequal to that in the instance data for the same namespace.
> -------------------------------------------------------------------------=
-------------------------------------------------------------
>
>                 Key: COCOON-1686
>                 URL: https://issues.apache.org/jira/browse/COCOON-1686
>             Project: Cocoon
>          Issue Type: Bug
>          Components: Blocks: Forms
>    Affects Versions: 2.1.8
>            Reporter: Michael Schlotfeldt
>         Attachments: DomHelper.txt, JXPathBindingManager.txt
>
>
> This is a patch to solve bug entry COCOON-1671.
> The problem was the SAX parser used in createBinding(Source) of JXPathBin=
dingManager did not have the "http://xml.org/sax/features/namespace-prefixe=
s" set to true. This ment the namespaces could not be extracted from the DO=
M when calling getInheritedNSDeclarations(Element). Therefore the JXPathCon=
text was never having namespaces registered.
> Enabling the features solves these problems. The patch (which is against =
the SVN as of today) that are being submit changes 2 files: (1) DomHelper.j=
ava (2)JXPathBindingMangager
> In DomHelper I added an additional parse method that takes a SAXParser in=
 place of the servicemanager. This way you can set features on the SAXParse=
r before the parsing to dom is done. The parse method that existed before s=
till does but i modified that as well so it uses the new method so we do no=
t duplicate code.
> Three more things:
> 1. My experinece with Excalibur is not complete. I am unsure if i can loo=
kup the SAXParser and then parametize it. Or if it should be done another w=
ay. The patch looks it up and then parametizes this. I believe this is the =
correct way, but if it is not please let me know.
> 2. The SAXParser used by JXPathBindingMangager no turns on the feature we=
 want. But the JaxpParser class from Excalibur (which is what is returned) =
has a system print out in it if you enable the feature we are now.  So ever=
ytime a binding occurs it says: "NAMESPACE PREFIX!!!!!!!!!!!!!!!!!!!!!!!!!!=
". If anybody has acces to the repository for that class PLEASE remove that=
 line. It shoudl not be there.
> 3. There is another bug report for the form samples (#6) that uses namesp=
ace binding. I need somebody to confirm this but it appears that this patch=
 also fixes that bug report. The number for that report is:   COCOON-1595

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.