cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giacomo Pati <giac...@apache.org>
Subject Re: svn commit: r540144 - in /cocoon/trunk/core/cocoon-configuration/cocoon-spring-configurator/src/main: java/org/apache/cocoon/spring/configurator/impl/ resources/META-INF/ resources/org/apache/cocoon/spring/configurator/schema/
Date Tue, 22 May 2007 05:10:11 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Grzegorz Kossakowski wrote:
> giacomo@apache.org pisze:
>> Author: giacomo
>> Date: Mon May 21 06:52:41 2007
>> New Revision: 540144
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=540144
>> Log:
>> enhance the bean-map for service servlet use case
> 
> Giacomo, thanks for implementing this. I have few comments:
> 1. Could you please provide links to the thread discussing applied
> changes? It really helps to understand these changes 2 months later.

Well, the changes are freshly discussed (not 2 month later). The changes to the bean-map provider
is
the refactoring of the DispatcherServlet's logic collecting block servlets (as discussed in
the
recent thread about DispatcherServlet)

> 2. If you modify schema don't forget to publish changes, otherwise
> people's svn copies will break soon or later. (I've done it myself
> already so don't bother yourself)

Thanks. Didn't know they need to be published.

> 3. Could you please add information about your changes to changes.xml file?

I have not thought that change would have enough importance to be mentioned there!

> I have updated the schema by moving your comments to xsd:documentation
> elements. I hope you don't mind.

Thanks alot, it's your code as well as mine ;-)

- --
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (GNU/Linux)

iD8DBQFGUnszLNdJvZjjVZARAgO1AJ9CH5NDDGalOgmWsdTIARAbeDXhTgCfdTrg
W4JFPCM90nLKKeudmNeCnjE=
=xPAU
-----END PGP SIGNATURE-----

Mime
View raw message