Return-Path: Delivered-To: apmail-cocoon-dev-archive@www.apache.org Received: (qmail 21652 invoked from network); 3 Apr 2007 19:12:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Apr 2007 19:12:23 -0000 Received: (qmail 89296 invoked by uid 500); 3 Apr 2007 19:12:29 -0000 Delivered-To: apmail-cocoon-dev-archive@cocoon.apache.org Received: (qmail 89022 invoked by uid 500); 3 Apr 2007 19:12:28 -0000 Mailing-List: contact dev-help@cocoon.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@cocoon.apache.org List-Id: Delivered-To: mailing list dev@cocoon.apache.org Received: (qmail 89006 invoked by uid 99); 3 Apr 2007 19:12:28 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Apr 2007 12:12:28 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [216.86.168.178] (HELO mxout-03.mxes.net) (216.86.168.178) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Apr 2007 12:12:18 -0700 Received: from [192.168.1.4] (unknown [87.206.142.101]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.mxes.net (Postfix) with ESMTP id DF448519EA for ; Tue, 3 Apr 2007 15:11:56 -0400 (EDT) Message-ID: <4612A6F8.1060906@apache.org> Date: Tue, 03 Apr 2007 21:11:52 +0200 From: Grzegorz Kossakowski User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: dev@cocoon.apache.org Subject: Re: Circular deps in servlet connections (was Re: Servlet Services + Shielding) References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org Alexander Klimetschek napisaƂ(a): > Oh, I got it: there was a circular dependency in the servlet connections > (A using B, B using A as super). It did work with the old block > servlets, but now you get the very unhelpful exception. I don't think we > actually need this circular connection in particular. But generally, two > solutions are available: > > Is it possible to allow circular dependencies in the servlet connections? > > If not, there should be at least some kind of check that prints a better > message. > My opinion is that circular dependencies should not be allowed and I agree that more meaningful exception is needed here. Could you please create an issue for this? Providing a patch would be even more appreciated. If you are going to work on it please let me know to not duplicate the effort. -- Grzegorz Kossakowski